update type definitions for unstable_batchedUpdates #36180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
8 tasks
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Feb 17, 2023
|
This pull request was successfully merged by @k-yle in 71157f6. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This PR fixes the type definitions for `unstable_batchedUpdates`. The same change was recently made on DefinitelyTyped - see DefinitelyTyped/DefinitelyTyped#63517 for a more detailed explanation ## Changelog [General] [Fixed] - fix type definition for `unstable_batchedUpdates` Pull Request resolved: facebook#36180 Test Plan: Note how the typescript defintions now match [the flow definitions](https://github.com/facebook/react-native/blob/43636267011a97490ed7495b08e500c5d0d54872/Libraries/ReactNative/RendererImplementation.js#L99), and note how [the tests in DefinitelyTyped](https://github.com/k-yle/DefinitelyTyped/blob/a4e15e3c2b9c6d689918cbbfa98c02cd26fe7681/types/react-dom/test/react-dom-tests.tsx#L231-L238) are passing. Reviewed By: christophpurrer, cortinico Differential Revision: D43367314 Pulled By: lunaleaps fbshipit-source-id: 74351daaf2c00a372f4e28992d41ebd2cbb1c7cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the type definitions for
unstable_batchedUpdates. The same change was recently made on DefinitelyTyped - see DefinitelyTyped/DefinitelyTyped#63517 for a more detailed explanationChangelog
[General] [Fixed] - fix type definition for
unstable_batchedUpdatesTest Plan
Note how the typescript defintions now match the flow definitions, and note how the tests in DefinitelyTyped are passing.