-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add width, height and crossOrigin props on Image type declaration file #36196
fix: add width, height and crossOrigin props on Image type declaration file #36196
Conversation
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@alvessteve Looks ok to me, but please do take into account the @carlosalmonte04 comment. |
TL;DR: It's more organized having PR's be associated to a specific task. I guess it's not a big deal around here. |
thank you for the comments @carlosalmonte04 and @rshest ! As it was no big deal here, I put them together but next time I will split it. |
Thank you. Please do. Otherwise it brings down repo morale and reputation. |
…n file (facebook#36196) Summary: According this Issue [`https://github.com/facebook/react-native/issues/36182`](https://github.com/facebook/react-native/issues/36182), the typescript compiler doesn't know the `width`, `height` and `crossOrigin` props for the `Image` component although they are taken in account in the code, [docs](https://reactnative.dev/docs/image#crossorigin) and the flow types. ## Changelog [GENERAL] [FIXED] - Fix missing `height`, `width`, `crossOrigin` props on Typescript Image.d.ts file Pull Request resolved: facebook#36196 Reviewed By: christophpurrer Differential Revision: D43406094 Pulled By: rshest fbshipit-source-id: 547ed142d7c39c361d195275b79b0885ef829ba1
Summary
According this Issue
#36182
, the typescript compiler doesn't know thewidth
,height
andcrossOrigin
props for theImage
component although they are taken in account in the code, docs and the flow types.Changelog
[GENERAL] [FIXED] - Fix missing
height
,width
,crossOrigin
props on Typescript Image.d.ts file