-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUGGING: Bump Ruby to 3.1.3 #36205
Conversation
…hing Ruby version
…hing Ruby version
Hi @traviswimer! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Base commit: 23eb380 |
Converting this to draft |
Removes possibly unnecessary python unlinking.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@@ -593,11 +601,7 @@ jobs: | |||
- run: | |||
name: "Brew: Tap wix/brew" | |||
command: brew tap wix/brew | |||
- run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just added in a PR (#36192), but it seems the python installation is no longer causing CI tests to break. Instead, this brew unlink
command was throwing an error.
Basically, the problems I fixed to make Ruby 3.1.3 work are:
Now the tests are all passing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me, thank you for taking care of the bump!
@traviswimer could you condense the changelog lines into a single one? I think that the changelog tool could have an hard time in handling three different |
@cipolleschi Sure, I updated it. |
Thank you so much! |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hi @traviswimer. Thank you so much for this PR: it was extremely helpful and instrumental to kickstart an internal discussion with the React org about the DevX we want to provide related to Ruby. Currently, we are enforcing a specific version of Ruby which push all our users to either update their current version of Ruby or install a Ruby version manager. This could be challenging, especially for new users that approaches React Native for the first time and for users that comes from a Web background and have no platform-specific knowledge. After considering this use cases, we decided to adopt a less strict approach. From now on, React Native will try to support a wider range of Ruby versions, from the system Ruby ( Due to these consideration, we won't be able to merge this PR. However, thank you so much for the work you put into it and I hope you will still considering contributing to the project as we think that your contributions could help the framework improve. Thank you so much! 🙇 |
Summary
This was forked from another PR to bump Ruby to version 3.1.3: #36074
I'm only making this PR for debugging purposes, so that CircleCI will run the tests with my changes.
Changelog
[GENERAL] [CHANGED] - Updates CircleCI config to install and use Ruby 3.1.3
Test Plan
See if CircleCI tests pass.