fix(ios): fix nullability warnings #36247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: While testing `use_frameworks! :linkage => :static`, I encountered nullability warnings that were previously suppressed because we always build with `-Werror`. I'm not sure why the suppressions no longer work, but they should just be fixed. ## Changelog [IOS] [FIXED] - Fix nullability warnings Pull Request resolved: facebook#36247 Test Plan: iOS build should succeed. Reviewed By: cipolleschi Differential Revision: D43531887 Pulled By: javache fbshipit-source-id: cae0617a20c8d215042cf4c5be2cbb17c801bb41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While testing
use_frameworks! :linkage => :static, I encountered nullability warnings that were previously suppressed because we always build with-Werror. I'm not sure why the suppressions no longer work, but they should just be fixed.Changelog
[IOS] [FIXED] - Fix nullability warnings
Test Plan
iOS build should succeed.