Fix/animated lists types

[jeongshin]

Summary

I was working on Animated.FlatList and found some types missing as below

also Animated.SectionList

So I refactored type definition for Animated.FlatList and Animated.SectionList using abstract class.

Changelog

[GENERAL] [FIXED] - add missing FlatList types for Animated FlatList
[GENERAL] [FIXED] - add missing SectionList types for Animated SectionList

Test Plan

Ran yarn test-typescript and yarn test-typescript-offline with no errors.

[facebook-github-bot]

Hi @jeongshin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,471,413	-1,060
android	hermes	armeabi-v7a	7,793,521	-1,266
android	hermes	x86	8,946,844	-1,483
android	hermes	x86_64	8,804,129	-1,450
android	jsc	arm64-v8a	9,105,268	-1,241
android	jsc	armeabi-v7a	8,302,211	-1,456
android	jsc	x86	9,155,600	-1,671
android	jsc	x86_64	9,414,658	-1,639

Base commit: 81dd3af
Branch: main

[NickGerleman]

Can we factor this to reuse the imperative methods already defined for VirtualizedList, instead of duplicating this?

[jeongshin]

Can we factor this to reuse the imperative methods already defined for VirtualizedList, instead of duplicating this?

I tried to use abstract class to reuse the imperative methods.
Thank you 🙏

[redpanda-bit]

NodeHandle is not in use.

[jeongshin]

Removed unused type. thank you.

[redpanda-bit]

Do you think it is a good idea to make changes only on Animated.d.ts and not change Flatlist.d.ts and SectionList.d.ts? Otherwise this looks good to me.

[jeongshin]

Do you think it is a good idea to make changes only on Animated.d.ts and not change Flatlist.d.ts and SectionList.d.ts? Otherwise this looks good to me.

I made changes only on Animated.d.ts to fix Animated.FlatList type definition not supporting Animated.FlatList method types which shares with FlatList. (scrollToIndex, scrollToItem, ... etc).

So, I fixed Animated.FlatList to extends FlatList types including method types.

[facebook-github-bot]

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@NickGerleman merged this pull request in ed39d63.