FileReader#readAsArrayBuffer #36332
Closed
FileReader#readAsArrayBuffer #36332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: André Costa Lima <andreclima.pt@gmail.com>
facebook-github-bot
added
the
CLA Signed
Base commit: a0adf57 |
Pranav-yadav
reviewed
Mar 1, 2023
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
+1 |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Fixes a number of issues with third party libraries that use `Blob#arrayBuffer` or `FileReader#readAsArrayBuffer`, including facebook#30769 facebook#34402 facebook#20091 facebook#21209 ## Changelog [INTERNAL] [FIXED] - Implemented FileReader#readAsArrayBuffer Pull Request resolved: facebook#36332 Test Plan: Added a test which fails against current release but passes after code changes. Reviewed By: christophpurrer Differential Revision: D43907171 Pulled By: javache fbshipit-source-id: 73d622ec569a282b6394732b9a0dc687b447fb62
cbjs
reviewed
Sep 8, 2023
| const base64 = text.split(',')[1]; | ||
| const typedArray = toByteArray(base64); | ||
|
|
||
| this._result = typedArray.buffer; |
There was a problem hiding this comment.
not working on react-native@0.72.4
empty buffer, return typedArray directly is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a number of issues with third party libraries that use
Blob#arrayBufferorFileReader#readAsArrayBuffer, including #30769 #34402 #20091 #21209Changelog
[INTERNAL] [FIXED] - Implemented FileReader#readAsArrayBuffer
Test Plan
Added a test which fails against current release but passes after code changes.