Improve handling of invalid DimensionValue usage #36346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43153075 |
react-native-bot
added
the
Type: Enhancement
Summary: Pull Request resolved: facebook#36346 1. Remove Paper native assertions for converting DimensionValue string to Yoga unit, and fix a case where Fabric could throw on invalid value. 2. Move DimensionValue types in TypeScript to use template literal types, to show malformed strings in-editor, during typechecking. Update min TS version to allow this (in conformance with the min TS version used by DefinitelyTyped). Changelog: [General][Added] - Improve handling of invalid DimensionValue usage Differential Revision: D43153075 fbshipit-source-id: 84ca0e1fca88c97b44482e8e98d07c918a12bea1
Base commit: 71157f6 |
NickGerleman
force-pushed
the
export-D43153075
branch
from
de9fc7c to
324464f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43153075 |
|
This pull request has been merged in 02e29ab. |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 3, 2023
Summary: ## Changelog: [General][Fixed] - facebook#36346 added some typing improvements, however there was a typo in `AnimatableStringValue` type definition, that broke tests on CI. Reviewed By: cortinico, cipolleschi, hoxyq Differential Revision: D43770412 fbshipit-source-id: dc54a3593989050f5680c67c67fb61ed7d367c2f
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 3, 2023
Summary: Pull Request resolved: #36366 ## Changelog: [General][Fixed] - #36346 added some typing improvements, however there was a typo in `AnimatableStringValue` type definition, that broke tests on CI. Reviewed By: cortinico, cipolleschi, hoxyq Differential Revision: D43770412 fbshipit-source-id: 7b4f234b5cf04df9271e0c98cf51655c87e3bebb
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36346 1. Remove Paper native assertions for converting DimensionValue string to Yoga unit, and fix a case where Fabric could throw on invalid value. 2. Move DimensionValue types in TypeScript to use template literal types, to show malformed strings in-editor, during typechecking. Update min TS version to allow this (in conformance with the min TS version used by DefinitelyTyped). Changelog: [General][Added] - Improve handling of invalid DimensionValue usage Reviewed By: javache Differential Revision: D43153075 fbshipit-source-id: db4e813df6e81cbd3158edad7c07c7a90c009803
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36366 ## Changelog: [General][Fixed] - facebook#36346 added some typing improvements, however there was a typo in `AnimatableStringValue` type definition, that broke tests on CI. Reviewed By: cortinico, cipolleschi, hoxyq Differential Revision: D43770412 fbshipit-source-id: 7b4f234b5cf04df9271e0c98cf51655c87e3bebb
|
@NickGerleman doesn't DimensionValue also support px strings eg. |
As of today, no. Please see:
There are some caveats. I think under the new architecture, the parser might end up being more permissive, and interpret anything starting with a number as a px value.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General][Added] - Improve handling of invalid DimensionValue usage
Differential Revision: D43153075