Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-declare imports in Binding and FabricMountingManager #36609

Closed
wants to merge 1 commit into from

Commits on Mar 23, 2023

  1. Forward-declare imports in Binding and FabricMountingManager (faceboo…

    …k#36609)
    
    Summary:
    Pull Request resolved: facebook#36609
    
    Some random cleanup as I prepare to make these classes a better injection point for future experiments.
    
    * Forward-declare classes where possible to reduce header import
    * Return references to shared_ptr instead of copies when there are no lifetime concerns
    * Use a shared JClass instance in JFabricUIManager
    
    Changelog: [Internal]
    
    Reviewed By: rshest
    
    Differential Revision: D44221018
    
    fbshipit-source-id: 2cf673f6ef5cdf69fa7369c8561ba059662ddb0c
    javache authored and facebook-github-bot committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    b895fdc View commit details
    Browse the repository at this point in the history