Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing include #36708

Closed
wants to merge 1 commit into from
Closed

Conversation

janondrusek
Copy link

Summary:
#include what you use!

Changelog: [Internal]

Reviewed By: ispeters

Differential Revision: D44516344

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 29, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44516344

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only the compiler would fail in these cases... 🙄

Thank you for this fix!

@analysis-bot
Copy link

analysis-bot commented Mar 29, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,547,536 +5
android hermes armeabi-v7a 7,861,918 +7
android hermes x86 9,029,444 -3
android hermes x86_64 8,884,498 +2
android jsc arm64-v8a 9,167,632 +0
android jsc armeabi-v7a 8,358,039 +7
android jsc x86 9,224,300 -4
android jsc x86_64 9,482,153 -9

Base commit: 66ae98e
Branch: main

Summary:
Pull Request resolved: facebook#36708

`#include` what you use!

Changelog: [Internal]

Reviewed By: ispeters

Differential Revision: D44516344

fbshipit-source-id: d2000fc1beaf76dabce904031ea7013bb32940ae
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44516344

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 30, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d1277df.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36708

`#include` what you use!

Changelog: [Internal]

Reviewed By: ispeters

Differential Revision: D44516344

fbshipit-source-id: a96afe7a7098609270f1d25321133a9afb443db2
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36708

`#include` what you use!

Changelog: [Internal]

Reviewed By: ispeters

Differential Revision: D44516344

fbshipit-source-id: a96afe7a7098609270f1d25321133a9afb443db2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants