Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xcode): backport Xcode 14.3 fix to 69 #36767

Merged
merged 3 commits into from
Apr 3, 2023
Merged

fix(xcode): backport Xcode 14.3 fix to 69 #36767

merged 3 commits into from
Apr 3, 2023

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Apr 3, 2023

Summary:

A quick attempt at a minimal fix for 0.69 for #36739, based on #36759

Changelog:

[IOS] [FIXED] - Fix React Codegen podspec to build on Xcode 14.3

Test Plan:

@kelset kelset requested a review from cipolleschi April 3, 2023 10:12
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Apr 3, 2023
cipolleschi
cipolleschi requested changes Apr 3, 2023
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@kelset kelset requested a review from cipolleschi April 3, 2023 10:44
@analysis-bot
Copy link

analysis-bot commented Apr 3, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,571,368 -997,641
android hermes armeabi-v7a 6,998,312 -885,088
android hermes x86 7,868,592 -1,182,335
android hermes x86_64 7,842,152 -1,063,802
android jsc arm64-v8a 9,444,121 +276,390
android jsc armeabi-v7a 8,240,144 -117,988
android jsc x86 9,381,821 +157,423
android jsc x86_64 9,972,766 +490,530

Base commit: 9504720
Branch: main

@cipolleschi cipolleschi mentioned this pull request Apr 3, 2023
Closed
@kelset kelset mentioned this pull request Apr 3, 2023
Closed
@kelset kelset merged commit 74ba411 into 0.69-stable Apr 3, 2023
@kelset kelset deleted the kelset/backport-xcode-143-fix-69 branch April 3, 2023 15:01
@focux
Copy link

focux commented Apr 3, 2023

Awesome, when is this going to be released, or is there a quick fix that we can implement meanwhile?

@archcorsair
Copy link

Awesome, when is this going to be released, or is there a quick fix that we can implement meanwhile?

It has been released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kelset @analysis-bot @focux @archcorsair @cipolleschi @facebook-github-bot