New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaping in the URL conversion #36898

Closed

cipolleschi wants to merge 1 commit into facebook:main from cipolleschi:export-D44958172

Contributor

cipolleschi commented Apr 13, 2023

Summary:
This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to NSURLComponents. NSURLComponents provides us with more flexibility so that we could handle the missing cases.

Changelog:

[iOS][Fixed] - Handle doulbe # and partially escaped urls

Differential Revision: D44958172

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented Apr 13, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

1 similar comment

Contributor

facebook-github-bot commented Apr 13, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

19d67bd

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Differential Revision: D44958172

fbshipit-source-id: dd719d82a4fcb7dffaf674131b881a4978663714

cipolleschi force-pushed the export-D44958172 branch from 390709e to 19d67bd Compare

April 13, 2023 14:03

analysis-bot commented Apr 13, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,620,787	+0
android	hermes	armeabi-v7a	7,933,466	+0
android	hermes	x86	9,106,793	+0
android	hermes	x86_64	8,961,595	+0
android	jsc	arm64-v8a	9,186,843	+0
android	jsc	armeabi-v7a	8,377,136	+0
android	jsc	x86	9,244,445	+0
android	jsc	x86_64	9,502,916	+0

Base commit: ee2f488
Branch: main

Contributor

facebook-github-bot commented Apr 13, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

2bf2fdf

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Differential Revision: D44958172

fbshipit-source-id: 0a141da748b79d61cca82a1267413e79f54f6c24

cipolleschi force-pushed the export-D44958172 branch from 19d67bd to 2bf2fdf Compare

April 13, 2023 14:52

Contributor

facebook-github-bot commented Apr 14, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

c753bfa

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: 9c2d7c592a35c12232060d87c788c7131906b286

cipolleschi force-pushed the export-D44958172 branch from 2bf2fdf to c753bfa Compare

April 14, 2023 10:04

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

274392c

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: d61d9d36a4439871a00d8572146ac49d54c78066

Contributor

facebook-github-bot commented Apr 14, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

cipolleschi force-pushed the export-D44958172 branch from c753bfa to 274392c Compare

April 14, 2023 10:08

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

5ab8153

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: daca200c45a615740a5c87d8b6c6b195395e2b5b

cipolleschi force-pushed the export-D44958172 branch from 274392c to 5ab8153 Compare

April 14, 2023 10:15

Contributor

facebook-github-bot commented Apr 14, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

1 similar comment

Contributor

facebook-github-bot commented Apr 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

c67d62a

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: ac08a6f9246352041777da7b2446e4215d32bd37

cipolleschi force-pushed the export-D44958172 branch from 5ab8153 to c67d62a Compare

April 17, 2023 09:38

Contributor

facebook-github-bot commented Apr 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

21e6ec4

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: 6cc921c9f5fda248ad15edee9d38147931c24ff9

cipolleschi force-pushed the export-D44958172 branch from c67d62a to 21e6ec4 Compare

April 17, 2023 09:44

Contributor

facebook-github-bot commented Apr 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

60e12db

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: 9d92db30f97a9b5d69971a9dbf35361dc9568dad

cipolleschi force-pushed the export-D44958172 branch from 21e6ec4 to 60e12db Compare

April 17, 2023 09:50

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

f011e40

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: 46b8ac246b12e16b4599221a62c052268c5997a3

cipolleschi force-pushed the export-D44958172 branch from 60e12db to f011e40 Compare

April 17, 2023 10:57

Contributor

facebook-github-bot commented Apr 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: bff8bcad3fdce43d01221e14111290cc3ccbd9d2

cipolleschi force-pushed the export-D44958172 branch from f011e40 to 2769449 Compare

April 17, 2023 11:21

Contributor

facebook-github-bot commented Apr 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172


          Fix escaping in the URL conversion (facebook#36898)

910ac9f

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: 45bfa3135443208f6efba23f66d7952fa9dbc177

cipolleschi force-pushed the export-D44958172 branch from 2769449 to 910ac9f Compare

April 17, 2023 12:23

Contributor

facebook-github-bot commented Apr 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44958172

facebook-github-bot closed this in

2b4e1f5

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Apr 17, 2023

This pull request has been merged in 2b4e1f5.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

425d511

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: 03628d86966c149d0785ad90fdbccbcb5e70106e

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request


          Fix escaping in the URL conversion (facebook#36898)

0bae205

Summary:
Pull Request resolved: facebook#36898

This changes are a followup from D42281798 and the task T141309497.

In the previous diff, we were able to handle most cases thanks to `NSURLComponents`. `NSURLComponents` provides us with more flexibility so that we could handle the missing cases.

## Changelog:
[iOS][Fixed] - Handle doulbe `#` and partially escaped urls

Reviewed By: sammy-SC

Differential Revision: D44958172

fbshipit-source-id: 03628d86966c149d0785ad90fdbccbcb5e70106e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner