Restore 'import' in default Package Exports conditions #36902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44962143 |
Base commit: 3b4037e |
|
This pull request was exported from Phabricator. Differential Revision: D44962143 |
huntie
force-pushed
the
export-D44962143
branch
from
84d37b4
to
98311be
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Apr 14, 2023
Summary: Pull Request resolved: facebook#36902 Reverts facebook#36584. Since we've come across example packages (typically targeting Node.js) which only distribute ESM, we believe it's more helpful to return to asserting the `"import"` condition by default, for maximum compatibility. The above issue and comments outline the pros/cons. Changelog: [General][Changed] - Default condition set for experimental Package Exports is now ['require', 'import', 'react-native'] Metro changelog: [Experimental] Package Exports unstable_conditionNames now defaults to ['require', 'import'] Reviewed By: robhogan Differential Revision: D44962143 fbshipit-source-id: d2004df313c858c70bc41c5e096ae2ab9f627bc1
Summary: Pull Request resolved: facebook#36902 Reverts facebook#36584. Since we've come across example packages (typically targeting Node.js) which only distribute ESM, we believe it's more helpful to return to asserting the `"import"` condition by default, for maximum compatibility. The above issue and comments outline the pros/cons. Changelog: [General][Changed] - Default condition set for experimental Package Exports is now ['require', 'import', 'react-native'] Metro changelog: [Experimental] Package Exports unstable_conditionNames now defaults to ['require', 'import'] Reviewed By: robhogan Differential Revision: D44962143 fbshipit-source-id: f110182f37c07bc3fa5a3e6f936148e44b30a536
|
This pull request was exported from Phabricator. Differential Revision: D44962143 |
huntie
force-pushed
the
export-D44962143
branch
from
98311be
to
21900d4
Compare
|
This pull request has been merged in 808b3c9. |
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Apr 14, 2023
Summary: X-link: facebook/react-native#36902 Reverts facebook/react-native#36584. Since we've come across example packages (typically targeting Node.js) which only distribute ESM, we believe it's more helpful to return to asserting the `"import"` condition by default, for maximum compatibility. The above issue and comments outline the pros/cons. Changelog: [General][Changed] - Default condition set for experimental Package Exports is now ['require', 'import', 'react-native'] Metro changelog: [Experimental] Package Exports unstable_conditionNames now defaults to ['require', 'import'] Reviewed By: robhogan Differential Revision: D44962143 fbshipit-source-id: 004172388916c902469b49cfc920ebe13c62c430
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36902 Reverts facebook#36584. Since we've come across example packages (typically targeting Node.js) which only distribute ESM, we believe it's more helpful to return to asserting the `"import"` condition by default, for maximum compatibility. The above issue and comments outline the pros/cons. Changelog: [General][Changed] - Default condition set for experimental Package Exports is now ['require', 'import', 'react-native'] Metro changelog: [Experimental] Package Exports unstable_conditionNames now defaults to ['require', 'import'] Reviewed By: robhogan Differential Revision: D44962143 fbshipit-source-id: 004172388916c902469b49cfc920ebe13c62c430
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36902 Reverts facebook#36584. Since we've come across example packages (typically targeting Node.js) which only distribute ESM, we believe it's more helpful to return to asserting the `"import"` condition by default, for maximum compatibility. The above issue and comments outline the pros/cons. Changelog: [General][Changed] - Default condition set for experimental Package Exports is now ['require', 'import', 'react-native'] Metro changelog: [Experimental] Package Exports unstable_conditionNames now defaults to ['require', 'import'] Reviewed By: robhogan Differential Revision: D44962143 fbshipit-source-id: 004172388916c902469b49cfc920ebe13c62c430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reverts #36584.
Since we've come across example packages (typically targeting Node.js) which only distribute ESM, we believe it's more helpful to return to asserting the
"import"condition by default, for maximum compatibility. The above issue and comments outline the pros/cons.Changelog:
[General][Changed] - Default condition set for experimental Package Exports is now ['require', 'import', 'react-native']
Metro changelog: [Experimental] Package Exports unstable_conditionNames now defaults to ['require', 'import']
Differential Revision: D44962143