RN: Silently Fail onRequestPermissionsResult for Invalid Activities
#37047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45203319 |
Base commit: 555014a |
…facebook#37047) Summary: Pull Request resolved: facebook#37047 We're seeing scenarios where `onRequestPermissionsResult` is being invoked but the current activity does not implement `PermissionAwareActivity`. This should not crash the app. Changelog: [Android][Fixed] - Fix crash when Android requests permission with activity that does not implement `PermissionAwareActivity` Reviewed By: mdvacca Differential Revision: D45203319 fbshipit-source-id: c8c3d9a52b063674bf681da8a8116755eb1add37
|
This pull request was exported from Phabricator. Differential Revision: D45203319 |
yungsters
force-pushed
the
export-D45203319
branch
from
91df54c to
ed7d0e5
Compare
|
This pull request has been merged in cff4bc8. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…facebook#37047) Summary: Pull Request resolved: facebook#37047 We're seeing scenarios where `onRequestPermissionsResult` is being invoked but the current activity does not implement `PermissionAwareActivity`. This should not crash the app. Changelog: [Android][Fixed] - Fix crash when Android requests permission with activity that does not implement `PermissionAwareActivity` Reviewed By: mdvacca Differential Revision: D45203319 fbshipit-source-id: 4a6eb67ad67ae5c731c27301967b837b1286ccbb
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…facebook#37047) Summary: Pull Request resolved: facebook#37047 We're seeing scenarios where `onRequestPermissionsResult` is being invoked but the current activity does not implement `PermissionAwareActivity`. This should not crash the app. Changelog: [Android][Fixed] - Fix crash when Android requests permission with activity that does not implement `PermissionAwareActivity` Reviewed By: mdvacca Differential Revision: D45203319 fbshipit-source-id: 4a6eb67ad67ae5c731c27301967b837b1286ccbb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're seeing scenarios where
onRequestPermissionsResultis being invoked but the current activity does not implementPermissionAwareActivity. This should not crash the app.Changelog:
[Android][Fixed] - Fix crash when Android requests permission with activity that does not implement
PermissionAwareActivityReviewed By: mdvacca
Differential Revision: D45203319