Fix: a11y crash when an accessible link is ellipsized away #37050
+35
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 01d80c1 |
dhleong
force-pushed
the
dhleong/ellipsized-a11y-nodes
branch
from
b5ea6cb to
eb5d823
Compare
Comment on lines
+642
to
+646
| if (bounds == null) { | ||
| node.setContentDescription(""); | ||
| node.setBoundsInParent(new Rect(0, 0, 1, 1)); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Just curious, why we're not adding the "action" AccessibilityNodeInfoCompat.ACTION_CLICK as well; here?
Suggested change
| if (bounds == null) { | |
| node.setContentDescription(""); | |
| node.setBoundsInParent(new Rect(0, 0, 1, 1)); | |
| return; | |
| } | |
| if (bounds == null) { | |
| node.setContentDescription(""); | |
| node.addAction(AccessibilityNodeInfoCompat.ACTION_CLICK); | |
| node.setBoundsInParent(new Rect(0, 0, 1, 1)); | |
| return; | |
| } |
There was a problem hiding this comment.
The link has been ellipsized away so it's not visible (IE would not actually be tappable). The two checks above don't include it when there isn't a valid link, etc; that seemed to apply in this case, so I mirrored that approach.
|
@NickGerleman seems like no one reviewed this PR? |
NickGerleman
approved these changes
May 25, 2023
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NickGerleman merged this pull request in d54f486. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If an accessible link is ellipsized out of being rendered, the AccessibilityDelegate will still attempt to populate an accessibility node for it; doing so results in an invalid request to a TextLayout API, however, causing a crash. This crash occurs as soon as the element is rendered, so long as a Screen Reader (or app using similar a11y APIs) is enabled. This change uses a technique similar to those existing to make the node "blank" in such cases, so Talkback can filter it out—and, more importantly, not crash.
Changelog:
[Android] [Fixed] - Fix links hidden via ellipsis crashing screen readers
Test Plan:
ReactAccessibilityDelegate, this component crashes the app; with the changes, the component renders without problem.