Avoid retaining TurboModuleManager in AppDelegate #37104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 26, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC Differential Revision: D45310066 fbshipit-source-id: 9dd0a713cd6015d8ec147c8d98d8fa548b90cb16
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
force-pushed
the
export-D45310066
branch
from
85527d2 to
92801c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 26, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC Differential Revision: D45310066 fbshipit-source-id: 3cece290cb8c48cae7d7735ce227bd60065b5b47
javache
force-pushed
the
export-D45310066
branch
from
92801c2 to
ef8299d
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 26, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC Differential Revision: D45310066 fbshipit-source-id: 4129e5c3e614b62bbdba298b47b698f7c9f976d0
javache
force-pushed
the
export-D45310066
branch
from
ef8299d to
4e25612
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
Base commit: 0dcf81b |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 26, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 95f466a4266516b26dc37c8d5dbc697c545973c9
javache
force-pushed
the
export-D45310066
branch
from
4e25612 to
d06bbb0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 26, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 416105a3fdf03ed0b4f7330c5ba5fd7fe7be21c2
javache
force-pushed
the
export-D45310066
branch
from
d06bbb0 to
a5860f2
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 26, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 51ab1031b7573118ba664d981aa9eaaf061b4146
javache
force-pushed
the
export-D45310066
branch
from
a5860f2 to
d83a5e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 26, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 8f369ecd980332acbd4c08d872c9296233221991
javache
force-pushed
the
export-D45310066
branch
from
d83a5e4 to
c327312
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 26, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 4ca8bc4b394f208ca2e7e817fa247e921a437052
javache
force-pushed
the
export-D45310066
branch
from
c327312 to
d794de3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
force-pushed
the
export-D45310066
branch
from
d794de3 to
a2dd5be
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 2363d57527eca0b3ceee25fb32159029423a16b1
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 378c11710d119198782f7a4cba9781842a72e8bc
javache
force-pushed
the
export-D45310066
branch
from
a2dd5be to
818f01e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: d28b4a24ebf745c5faea6b29390bc62aca949172
javache
force-pushed
the
export-D45310066
branch
from
818f01e to
4dc795a
Compare
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 5263280e14d959f0d7530571e2614a59c8838088
|
This pull request was exported from Phabricator. Differential Revision: D45310066 |
javache
force-pushed
the
export-D45310066
branch
from
4dc795a to
7050567
Compare
|
This pull request has been merged in ec1ab73. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 4199c9973d832cc07fd32b94f2dcbaa72f4d3920
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#37104 The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context. Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager. Reviewed By: sammy-SC, cipolleschi Differential Revision: D45310066 fbshipit-source-id: 4199c9973d832cc07fd32b94f2dcbaa72f4d3920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The AppDelegate (and other similar classes) only need to construct the TurboModuleManager for intialization purposes, and should not retain it beyond that. TurboModuleManager retains each of the TurboModule instances and through the new binding mechanism, also JSI pointers, which are invalid beyond the lifetime of the JS context.
Changelog: [iOS] Changed AppDelegate template to avoid retaining TurboModuleManager.
Differential Revision: D45310066