Define Flag operators for YGPrintOptions #37115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45341504 |
Base commit: 33ebb5d |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37115 Pull Request resolved: facebook#1267 This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset. Differential Revision: D45341504 fbshipit-source-id: b3cac41f466404b93408ee0c413a3a79e6955769
|
This pull request was exported from Phabricator. Differential Revision: D45341504 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37115 X-link: facebook/yoga#1267 This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset. Differential Revision: D45341504 fbshipit-source-id: 96b582177407f62ef2ae85d6d90b512e7f30c8c4
NickGerleman
force-pushed
the
export-D45341504
branch
from
c231dba to
756ab07
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37115 Pull Request resolved: facebook#1267 This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset. Differential Revision: D45341504 fbshipit-source-id: 3bfec11d0d1a7b6a0f4b9e092f15a3c4d5bacd51
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37115 X-link: facebook/yoga#1267 This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset. Differential Revision: D45341504 fbshipit-source-id: 62a3e75b18b667c0cd30d19fe2088ddfd4f68c6e
NickGerleman
force-pushed
the
export-D45341504
branch
from
756ab07 to
048401d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45341504 |
Differential Revision: D45254098 fbshipit-source-id: b057170421d6a748633142406a91a9ac7e10732a
Summary: Pull Request resolved: facebook#37115 X-link: facebook/yoga#1267 This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset. Reviewed By: rshest Differential Revision: D45341504 fbshipit-source-id: 3c6a416a1e4ec178c2256dfa96575a7d7d1e2fca
NickGerleman
force-pushed
the
export-D45341504
branch
from
048401d to
6159fc9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45341504 |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37115 Pull Request resolved: #1267 This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset. Reviewed By: rshest Differential Revision: D45341504 fbshipit-source-id: 0b80588f3e2e167d4c1c722c6d6608408dd617ba
|
This pull request has been merged in fe6f70b. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37115 X-link: facebook/yoga#1267 This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset. Reviewed By: rshest Differential Revision: D45341504 fbshipit-source-id: 0b80588f3e2e167d4c1c722c6d6608408dd617ba
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37115 X-link: facebook/yoga#1267 This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset. Reviewed By: rshest Differential Revision: D45341504 fbshipit-source-id: 0b80588f3e2e167d4c1c722c6d6608408dd617ba
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#37115 X-link: facebook/yoga#1267 This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset. Reviewed By: rshest Differential Revision: D45341504 fbshipit-source-id: 0b80588f3e2e167d4c1c722c6d6608408dd617ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is an existing bitset enum in the API. Use the facility added in the last diff to add flag operators to it, to avoid the need for casting, and to make it clearer in the generated YGEnums.h that it is a bitset.
Differential Revision: D45341504