Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Arrays in generator #37145

Closed
wants to merge 2 commits into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
This diff adds the generation of Array types in events.

It supports the generation of Array of:

  • Boolean
  • Int32
  • Float
  • Double
  • String
  • Objects
  • Array

Note: This is a first iteration. We could improve the generation further by leveraging the Bridging module within React Native.
I'll take a stab at it in a next diff.

Changelog:

[General][Added] - Generate events with arrays

Differential Revision: D45321685

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 28, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45321685

@analysis-bot
Copy link

analysis-bot commented Apr 28, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,629,446 +4
android hermes armeabi-v7a 7,941,030 -1
android hermes x86 9,115,986 +1
android hermes x86_64 8,970,291 -2
android jsc arm64-v8a 9,193,595 -3
android jsc armeabi-v7a 8,382,655 +3
android jsc x86 9,251,493 +0
android jsc x86_64 9,509,441 +1

Base commit: 1cd0f57
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45321685

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 2, 2023
Summary:
Pull Request resolved: facebook#37145

This diff adds the generation of Array types in events.

It supports the generation of Array of:
- Boolean
- Int32
- Float
- Double
- String
- Objects
- Array

**Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native.
I'll take a stab at it in a next diff.

## Changelog:
[General][Added] - Generate events with arrays

Differential Revision: D45321685

fbshipit-source-id: 2544ad151738fd4ba185b20fe17daa09b8d98d48
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 2, 2023
Summary:
Pull Request resolved: facebook#37145

This diff adds the generation of Array types in events.

It supports the generation of Array of:
- Boolean
- Int32
- Float
- Double
- String
- Objects
- Array

**Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native.
I'll take a stab at it in a next diff.

## Changelog:
[General][Added] - Generate events with arrays

Differential Revision: D45321685

fbshipit-source-id: 01f4d04c81acb26fe8447cf4732c3f72f9627585
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45321685

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45321685

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 3, 2023
Summary:
Pull Request resolved: facebook#37145

This diff adds the generation of Array types in events.

It supports the generation of Array of:
- Boolean
- Int32
- Float
- Double
- String
- Objects
- Array

**Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native.
I'll take a stab at it in a next diff.

## Changelog:
[General][Added] - Generate events with arrays

Differential Revision: D45321685

fbshipit-source-id: 63b19bb627d37bf4276cc9e69c84f63db2a35cfd
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 4, 2023
Summary:
Pull Request resolved: facebook#37145

This diff adds the generation of Array types in events.

It supports the generation of Array of:
- Boolean
- Int32
- Float
- Double
- String
- Objects
- Array

**Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native.
I'll take a stab at it in a next diff.

## Changelog:
[General][Added] - Generate events with arrays

Reviewed By: cortinico

Differential Revision: D45321685

fbshipit-source-id: e968e62c6f0c56accd64280201dfbc5ac7643501
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45321685

Riccardo Cipolleschi and others added 2 commits May 4, 2023 02:39
Summary:
This diff introduce support to parse arrays in events.

We support parsing Arrays of:
- Boolean
- Double
- Float
- Int32
- String Enums
- String
- Objects
- Arrays

## Changelog:
[General][Added] - Add generic support for Arrays in Events parsing

Differential Revision: https://internalfb.com/D45268779

fbshipit-source-id: 0f1cddfba5274ae18c48f864afbb8ef9d6213131
Summary:
Pull Request resolved: facebook#37145

This diff adds the generation of Array types in events.

It supports the generation of Array of:
- Boolean
- Int32
- Float
- Double
- String
- Objects
- Array

**Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native.
I'll take a stab at it in a next diff.

## Changelog:
[General][Added] - Generate events with arrays

Reviewed By: cortinico

Differential Revision: D45321685

fbshipit-source-id: 3e0435e4d17a45f3f02d7cc6b56af73e3609b56a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45321685

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 4, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b422375.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#37145

This diff adds the generation of Array types in events.

It supports the generation of Array of:
- Boolean
- Int32
- Float
- Double
- String
- Objects
- Array

**Note:** This is a first iteration. We could improve the generation further by leveraging the `Bridging` module within React Native.
I'll take a stab at it in a next diff.

## Changelog:
[General][Added] - Generate events with arrays

Reviewed By: cortinico

Differential Revision: D45321685

fbshipit-source-id: 34b05f5501b06714d1fabf1a51cb057af7027f00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants