-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix YG_DEPRECATED in MSVC C Build #37178
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
fb-exported
labels
Apr 30, 2023
This pull request was exported from Phabricator. Differential Revision: D45432859 |
Base commit: 7f300cd |
Summary: Pull Request resolved: facebook#37178 X-link: facebook/yoga#1272 Forgot to export this one to the Yoga repo to test the MSVC bits... Reviewed By: yungsters Differential Revision: D45432859 fbshipit-source-id: e505e73e135570bdf4587cefdf565a91032e1420
This pull request was exported from Phabricator. Differential Revision: D45432859 |
NickGerleman
force-pushed
the
export-D45432859
branch
from
April 30, 2023 17:17
5484acf
to
4931333
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 30, 2023
Summary: X-link: facebook/react-native#37178 Pull Request resolved: facebook#1272 Forgot to export this one to the Yoga repo to test the MSVC bits... Reviewed By: yungsters Differential Revision: D45432859 fbshipit-source-id: e7c939352e36ae1580e9942781e0dfe73935de07
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Apr 30, 2023
Summary: X-link: facebook/react-native#37178 Pull Request resolved: #1272 Forgot to export this one to the Yoga repo to test the MSVC bits... Reviewed By: yungsters Differential Revision: D45432859 fbshipit-source-id: 8d5f2daacb00daab67de111410329f8db80475e0
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Apr 30, 2023
Summary: X-link: facebook/react-native#37178 X-link: facebook/yoga#1272 Forgot to export this one to the Yoga repo to test the MSVC bits... Reviewed By: yungsters Differential Revision: D45432859 fbshipit-source-id: 8d5f2daacb00daab67de111410329f8db80475e0
This pull request has been merged in 97b2702. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37178 X-link: facebook/yoga#1272 Forgot to export this one to the Yoga repo to test the MSVC bits... Reviewed By: yungsters Differential Revision: D45432859 fbshipit-source-id: 8d5f2daacb00daab67de111410329f8db80475e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Forgot to export this one to the Yoga repo to test the MSVC bits...
Differential Revision: D45432859