Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YG_DEPRECATED in MSVC C Build #37178

Closed
wants to merge 1 commit into from

Conversation

NickGerleman
Copy link
Contributor

Summary: Forgot to export this one to the Yoga repo to test the MSVC bits...

Differential Revision: D45432859

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 30, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45432859

@analysis-bot
Copy link

analysis-bot commented Apr 30, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,628,253 -2
android hermes armeabi-v7a 7,940,458 -2
android hermes x86 9,115,071 -3
android hermes x86_64 8,969,775 -3
android jsc arm64-v8a 9,192,169 -2
android jsc armeabi-v7a 8,381,828 -3
android jsc x86 9,250,345 -4
android jsc x86_64 9,508,690 -1

Base commit: 7f300cd
Branch: main

Summary:
Pull Request resolved: facebook#37178

X-link: facebook/yoga#1272

Forgot to export this one to the Yoga repo to test the MSVC bits...

Reviewed By: yungsters

Differential Revision: D45432859

fbshipit-source-id: e505e73e135570bdf4587cefdf565a91032e1420
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45432859

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Apr 30, 2023
Summary:
X-link: facebook/react-native#37178

Pull Request resolved: facebook#1272

Forgot to export this one to the Yoga repo to test the MSVC bits...

Reviewed By: yungsters

Differential Revision: D45432859

fbshipit-source-id: e7c939352e36ae1580e9942781e0dfe73935de07
facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request Apr 30, 2023
Summary:
X-link: facebook/react-native#37178

Pull Request resolved: #1272

Forgot to export this one to the Yoga repo to test the MSVC bits...

Reviewed By: yungsters

Differential Revision: D45432859

fbshipit-source-id: 8d5f2daacb00daab67de111410329f8db80475e0
facebook-github-bot pushed a commit to facebook/litho that referenced this pull request Apr 30, 2023
Summary:
X-link: facebook/react-native#37178

X-link: facebook/yoga#1272

Forgot to export this one to the Yoga repo to test the MSVC bits...

Reviewed By: yungsters

Differential Revision: D45432859

fbshipit-source-id: 8d5f2daacb00daab67de111410329f8db80475e0
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 30, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 97b2702.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#37178

X-link: facebook/yoga#1272

Forgot to export this one to the Yoga repo to test the MSVC bits...

Reviewed By: yungsters

Differential Revision: D45432859

fbshipit-source-id: 8d5f2daacb00daab67de111410329f8db80475e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants