DevServerHelper should not depend on internal ctor parameter #37265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45600283 |
Base commit: 8aa2281 |
…k#37265) Summary: Pull Request resolved: facebook#37265 DevServerHelper was having a constructor parameter as `DevInternalSettings` which is effectively internal. This should not be the case as that class is Internal as was bleeding out of the public API. I've updated the primary constructor to take instead: ``` public DevServerHelper( DeveloperSettings settings, String packageName, InspectorPackagerConnection.BundleStatusProvider bundleStatusProvider, PackagerConnectionSettings packagerConnectionSettings) { ``` This is breaking change for users that were depending on the Internal class. Changelog: [Android] [Removed] - DevServerHelper should not depend on internal ctor parameter Reviewed By: mdvacca Differential Revision: D45600283 fbshipit-source-id: b8386ba8650546c3a8f5cec8574ef98f9e2f0494
|
This pull request was exported from Phabricator. Differential Revision: D45600283 |
cortinico
force-pushed
the
export-D45600283
branch
from
756c3cf to
8c2a451
Compare
|
This pull request has been merged in da358d0. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…k#37265) Summary: Pull Request resolved: facebook#37265 DevServerHelper was having a constructor parameter as `DevInternalSettings` which is effectively internal. This should not be the case as that class is Internal as was bleeding out of the public API. I've updated the primary constructor to take instead: ``` public DevServerHelper( DeveloperSettings settings, String packageName, InspectorPackagerConnection.BundleStatusProvider bundleStatusProvider, PackagerConnectionSettings packagerConnectionSettings) { ``` This is breaking change for users that were depending on the Internal class. Changelog: [Android] [Removed] - DevServerHelper should not depend on internal ctor parameter Reviewed By: mdvacca Differential Revision: D45600283 fbshipit-source-id: e73139dbdf5f2505201b2d2c8b5a9143b7e207ba
lukmccall
added a commit
to expo/expo
that referenced
this pull request
Jan 23, 2024
# Why Closes #26364. # How This PR: facebook/react-native#37265 changes how the packager connection is received. Now, it's passed next to the dev support settings, so our swapping logic didn't cover that. # Test Plan ``` - npx expo prebuild -p android --clean - cd ./android - ./gradlew app:assembleDebug - Install the apk from ./android/app/build/outputs/apk/debug on your physical device - npx expo start - Connect to the dev server ```
brentvatne
pushed a commit
to expo/expo
that referenced
this pull request
Jan 23, 2024
Closes #26364. This PR: facebook/react-native#37265 changes how the packager connection is received. Now, it's passed next to the dev support settings, so our swapping logic didn't cover that. ``` - npx expo prebuild -p android --clean - cd ./android - ./gradlew app:assembleDebug - Install the apk from ./android/app/build/outputs/apk/debug on your physical device - npx expo start - Connect to the dev server ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
DevServerHelper was having a constructor parameter as
DevInternalSettingswhich is effectively internal. This should not be the case as that class is Internal as was bleeding out of the public API.I've updated the primary constructor to take instead:
This is breaking change for users that were depending on the Internal class.
Changelog:
[Android] [Removed] - DevServerHelper should not depend on internal ctor parameter
Differential Revision: D45600283