delete RCTJSScriptLoaderModule #37284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45591882 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 5, 2023
Summary: Pull Request resolved: facebook#37284 Changelog: [iOS][Removed] in the past, we had this protocol so we could decorate the `RCTDevSplitBundleLoader`, which was removed by motiz88. now that doesn't exist anymore, we should delete this protocol. i did a quick grep on github and this protocol was only used by `RCTDevSplitBundleLoader`, so i don't think this will be a major breaking change Reviewed By: christophpurrer Differential Revision: D45591882 fbshipit-source-id: 79bb8b11af7d912b54c0a19572100f76f0938a47
|
This pull request was exported from Phabricator. Differential Revision: D45591882 |
Base commit: d24f568 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 5, 2023
Summary: Pull Request resolved: facebook#37284 Changelog: [iOS][Removed] in the past, we had this protocol so we could decorate the `RCTDevSplitBundleLoader`, which was removed by motiz88. now that doesn't exist anymore, we should delete this protocol. i did a quick grep on github and this protocol was only used by `RCTDevSplitBundleLoader`, so i don't think this will be a major breaking change Reviewed By: christophpurrer Differential Revision: D45591882 fbshipit-source-id: 610c401d6c2f48c5a29258e8f7a4bf2e72d280dd
|
This pull request was exported from Phabricator. Differential Revision: D45591882 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45591882 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 5, 2023
Summary: Pull Request resolved: facebook#37284 Changelog: [iOS][Removed] in the past, we had this protocol so we could decorate the `RCTDevSplitBundleLoader`, which was removed by motiz88. now that doesn't exist anymore, we should delete this protocol. i did a quick grep on github and this protocol was only used by `RCTDevSplitBundleLoader`, so i don't think this will be a major breaking change Reviewed By: christophpurrer Differential Revision: D45591882 fbshipit-source-id: 0d55af77edd18d6da2a9d6b21746d2d85cd4e6d0
|
This pull request was exported from Phabricator. Differential Revision: D45591882 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 5, 2023
Summary: Pull Request resolved: facebook#37284 Changelog: [iOS][Removed] in the past, we had this protocol so we could decorate the `RCTDevSplitBundleLoader`, which was removed by motiz88. now that doesn't exist anymore, we should delete this protocol. i did a quick grep on github and this protocol was only used by `RCTDevSplitBundleLoader`, so i don't think this will be a major breaking change Reviewed By: christophpurrer Differential Revision: D45591882 fbshipit-source-id: 1f0490a8c1f87065f31cf0e18363565a6eff3176
|
This pull request was exported from Phabricator. Differential Revision: D45591882 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 5, 2023
Summary: Pull Request resolved: facebook#37284 Changelog: [iOS][Removed] in the past, we had this protocol so we could decorate the `RCTDevSplitBundleLoader`, which was removed by motiz88. now that doesn't exist anymore, we should delete this protocol. i did a quick grep on github and this protocol was only used by `RCTDevSplitBundleLoader`, so i don't think this will be a major breaking change Reviewed By: christophpurrer Differential Revision: D45591882 fbshipit-source-id: 786486fd76d8e5683c645f677a437dcd9e112189
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 5, 2023
Summary: Pull Request resolved: facebook#37284 Changelog: [iOS][Removed] in the past, we had this protocol so we could decorate the `RCTDevSplitBundleLoader`, which was removed by motiz88. now that doesn't exist anymore, we should delete this protocol. i did a quick grep on github and this protocol was only used by `RCTDevSplitBundleLoader`, so i don't think this will be a major breaking change Reviewed By: christophpurrer Differential Revision: D45591882 fbshipit-source-id: 39f4d640cebd98abe8b5046c5b6a88813289677c
|
This pull request was exported from Phabricator. Differential Revision: D45591882 |
Differential Revision: D45582533 fbshipit-source-id: fc3c8781b80c0e5c16da456b61ad9b8f227fcdc5
Summary: Pull Request resolved: facebook#37284 Changelog: [iOS][Removed] in the past, we had this protocol so we could decorate the `RCTDevSplitBundleLoader`, which was removed by motiz88. now that doesn't exist anymore, we should delete this protocol. i did a quick grep on github and this protocol was only used by `RCTDevSplitBundleLoader`, so i don't think this will be a major breaking change Reviewed By: christophpurrer Differential Revision: D45591882 fbshipit-source-id: a366e445d246110f0dea76095ec0cf2682cbad0e
|
This pull request was exported from Phabricator. Differential Revision: D45591882 |
|
This pull request has been merged in 438f6cf. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37284 Changelog: [iOS][Removed] in the past, we had this protocol so we could decorate the `RCTDevSplitBundleLoader`, which was removed by motiz88. now that doesn't exist anymore, we should delete this protocol. i did a quick grep on github and this protocol was only used by `RCTDevSplitBundleLoader`, so i don't think this will be a major breaking change Reviewed By: christophpurrer Differential Revision: D45591882 fbshipit-source-id: 23656d0c04fa4e1c4cfc65b1052d4c3614ba8708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [iOS][Removed]
in the past, we had this protocol so we could decorate the
RCTDevSplitBundleLoader, which was removed by motiz88. now that doesn't exist anymore, we should delete this protocol. i did a quick grep on github and this protocol was only used byRCTDevSplitBundleLoader, so i don't think this will be a major breaking changeReviewed By: christophpurrer
Differential Revision: D45591882