Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix FlatList viewabilityConfig prop type #37299

Closed
wants to merge 1 commit into from

Conversation

jeongshin
Copy link
Contributor

Summary:

FlatList viewabilityConfig prop seems no need to be any type. So I replaced it with ViewabilityConfig from VirtualizedList.d.ts

Changelog:

[GENERAL] [FIXED] - change FlatList viewabilityConfig prop type any to ViewabilityConfig

Test Plan:

Ran yarn test-typescript and yarn test-typescript-offline with no errors.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,719,430 +0
android hermes armeabi-v7a 8,030,170 +2
android hermes x86 9,207,020 +2
android hermes x86_64 9,060,395 +4
android jsc arm64-v8a 9,283,795 +2
android jsc armeabi-v7a 8,471,966 +2
android jsc x86 9,342,762 +3
android jsc x86_64 9,599,758 +2

Base commit: e1876af
Branch: main

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 9, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 5dfa38a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants