Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jni_YGNodeDeallocateJNI call YGNodeDeallocate #37388

Closed
wants to merge 1 commit into from

Conversation

NickGerleman
Copy link
Contributor

Summary:
Fixes facebook/yoga#1271

Updating this glue was missed in D45556206 when moving from one revision to the other...

Differential Revision: D45780647

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 11, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45780647

@analysis-bot
Copy link

analysis-bot commented May 11, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,724,125 +19
android hermes armeabi-v7a 8,035,092 -8
android hermes x86 9,212,714 +24
android hermes x86_64 9,065,924 +26
android jsc arm64-v8a 9,288,858 +17
android jsc armeabi-v7a 8,477,259 -10
android jsc x86 9,348,845 +25
android jsc x86_64 9,605,658 +37

Base commit: 99674b3
Branch: main

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: facebook#37388

Fixes facebook/yoga#1271

Updating this glue was missed in D45556206 when moving from one revision to the other...

Reviewed By: yungsters

Differential Revision: D45780647

fbshipit-source-id: 60ea526d995d7a8096960a286628587e4c57c9f2
Summary:
Pull Request resolved: facebook#37388

Fixes facebook/yoga#1271

Updating this glue was missed in D45556206 when moving from one revision to the other...

Reviewed By: yungsters

Differential Revision: D45780647

fbshipit-source-id: 81b0159b198ff25a4de31313cb505b9b602308a4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45780647

facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request May 11, 2023
Summary:
X-link: facebook/react-native#37388

Fixes #1271

Updating this glue was missed in D45556206 when moving from one revision to the other...

Reviewed By: yungsters

Differential Revision: D45780647

fbshipit-source-id: 4ca64bc9971d3e4697990e73b618a3dc91df259b
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 11, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 92fc503.

facebook-github-bot pushed a commit to facebook/litho that referenced this pull request May 11, 2023
Summary:
X-link: facebook/react-native#37388

Fixes facebook/yoga#1271

Updating this glue was missed in D45556206 when moving from one revision to the other...

Reviewed By: yungsters

Differential Revision: D45780647

fbshipit-source-id: 4ca64bc9971d3e4697990e73b618a3dc91df259b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YogaNode Finalization is not thread safe
3 participants