Announce checkbox and radio button roles on VoiceOver #37414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45797554 |
Base commit: d8ced6f |
carmenvkrol
force-pushed
the
export-D45797554
branch
from
037c4d5 to
fcf1cc6
Compare
carmenvkrol
added a commit
to carmenvkrol/react-native
that referenced
this pull request
May 15, 2023
Summary: Pull Request resolved: facebook#37414 Previously, when focusing on a checkbox or radio button in React Native Fabric with VoiceOver, it wasn't announcing the role, e.g. "checkbox". Instead it would just say [label][state], e.g. "Automatically check for updates, unchecked". This is an extremely confusing experience for screen reader users because they don't know what kind of element they are focusing, including how to interact with it. "checkbox" and "radio button" aren't recognized as [Apple iOS traits](https://developer.apple.com/documentation/uikit/uiaccessibilitytraits?language=objc), but we'd like to have consistency with the mobile safari experience. Reviewed By: cipolleschi Differential Revision: D45797554 fbshipit-source-id: ec5213a385611e37a7d208c1d091ac5b1d9eac19
carmenvkrol
pushed a commit
to carmenvkrol/react-native
that referenced
this pull request
May 15, 2023
Summary: Pull Request resolved: facebook#37414 Previously, when focusing on a checkbox or radio button in React Native Fabric with VoiceOver, it wasn't announcing the role, e.g. "checkbox". Instead it would just say [label][state], e.g. "Automatically check for updates, unchecked". This is an extremely confusing experience for screen reader users because they don't know what kind of element they are focusing, including how to interact with it. "checkbox" and "radio button" aren't recognized as [Apple iOS traits](https://developer.apple.com/documentation/uikit/uiaccessibilitytraits?language=objc), but we'd like to have consistency with the mobile safari experience. Differential Revision: https://www.internalfb.com/diff/D45797554?entry_point=27 fbshipit-source-id: 6354a7687d2c70c2736aa8e426ba043f58f1f502
|
This pull request was exported from Phabricator. Differential Revision: D45797554 |
Summary: Pull Request resolved: facebook#37414 Previously, when focusing on a checkbox or radio button in React Native Fabric with VoiceOver, it wasn't announcing the role, e.g. "checkbox". Instead it would just say [label][state], e.g. "Automatically check for updates, unchecked". This is an extremely confusing experience for screen reader users because they don't know what kind of element they are focusing, including how to interact with it. "checkbox" and "radio button" aren't recognized as [Apple iOS traits](https://developer.apple.com/documentation/uikit/uiaccessibilitytraits?language=objc), but we'd like to have consistency with the mobile safari experience. Reviewed By: cipolleschi Differential Revision: D45797554 fbshipit-source-id: e00a4bdde39cc960aea26d46c5e7f4500ed80fef
carmenvkrol
pushed a commit
to carmenvkrol/react-native
that referenced
this pull request
May 15, 2023
Summary: Pull Request resolved: facebook#37414 Previously, when focusing on a checkbox or radio button in React Native Fabric with VoiceOver, it wasn't announcing the role, e.g. "checkbox". Instead it would just say [label][state], e.g. "Automatically check for updates, unchecked". This is an extremely confusing experience for screen reader users because they don't know what kind of element they are focusing, including how to interact with it. "checkbox" and "radio button" aren't recognized as [Apple iOS traits](https://developer.apple.com/documentation/uikit/uiaccessibilitytraits?language=objc), but we'd like to have consistency with the mobile safari experience. Differential Revision: https://www.internalfb.com/diff/D45797554?entry_point=27 fbshipit-source-id: d851c29f8e5ed1f77480b1ce261febde0e3ec62b
carmenvkrol
force-pushed
the
export-D45797554
branch
from
fcf1cc6 to
03cdb15
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45797554 |
|
This pull request has been merged in 12f4a19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, when focusing on a checkbox or radio button in React Native Fabric with VoiceOver, it wasn't announcing the role, e.g. "checkbox". Instead it would just say [label][state], e.g. "Automatically check for updates, unchecked". This is an extremely confusing experience for screen reader users because they don't know what kind of element they are focusing, including how to interact with it.
"checkbox" and "radio button" aren't recognized as Apple iOS traits, but we'd like to have consistency with the mobile safari experience.
Reviewed By: cipolleschi
Differential Revision: D45797554