create fallback contextContainer #37441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45805196 |
Differential Revision: D45804534 fbshipit-source-id: 76c96c02bd53160e9468c9d8c8a05c8b43880c7c
Differential Revision: D45805034 fbshipit-source-id: e13aaa0cb0da4d6652a98a5462ba7d488acb8950
Summary: Pull Request resolved: facebook#37441 Changelog: [Internal] i just noticed that `[_delegate createContextContainer]` can be null because it returns `shared_ptr`, we should protect against that! Reviewed By: javache Differential Revision: D45805196 fbshipit-source-id: 9b482753fe443ebf058cd8e9e1ef3b5190f53f12
|
This pull request was exported from Phabricator. Differential Revision: D45805196 |
Base commit: 066f0b7 |
|
This pull request has been merged in 11251c3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
i just noticed that
[_delegate createContextContainer]can be null because it returnsshared_ptr, we should protect against that!Reviewed By: javache
Differential Revision: D45805196