Terminate instead of throwing if TurboModule callback double-called #37570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46175685 |
Base commit: d4f6cf1 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 25, 2023
…acebook#37570) Summary: Pull Request resolved: facebook#37570 If a TM calls a completion callback, or resolves or rejects a promise multiple times, a C++ exception is thrown. For an in the wild crash, we are getting this signal as: 1. `libdispatch` calls std::terminate while pumping a thread's message queue 2. The hooked FB app termination handler is called, which introspects for the currently handled exception 4. We are handling this TurboModule C++ exception being thrown, suggesting `libdispatch` termination may be due to catching this C++ exception which was not otherwise handled 4. We have by this point lost the stack trace of the code invoking the callback I think if we change the timing of `abort()` to when the callback is called, we might be able to preserve the stack trace of module code calling the callback. Differential Revision: D46175685 fbshipit-source-id: 02494a7aed3ba8c105666281c879ff1805700c4f
NickGerleman
force-pushed
the
export-D46175685
branch
from
4976ff3 to
76b9764
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46175685 |
…acebook#37570) Summary: Pull Request resolved: facebook#37570 If a TM calls a completion callback, or resolves or rejects a promise multiple times, a C++ exception is thrown. For an in the wild crash, we are getting this signal as: 1. `libdispatch` calls std::terminate while pumping a thread's message queue 2. The hooked FB app termination handler is called, which introspects for the currently handled exception 4. We are handling this TurboModule C++ exception being thrown, suggesting `libdispatch` termination may be due to catching this C++ exception which was not otherwise handled 4. We have by this point lost the stack trace of the code invoking the callback I think if we change the timing of `abort()` to when the callback is called, we might be able to preserve the stack trace of module code calling the callback. Reviewed By: javache Differential Revision: D46175685 fbshipit-source-id: 5e53dda665bca0c221e4b6086209455a4d57cb36
NickGerleman
force-pushed
the
export-D46175685
branch
from
76b9764 to
4e94912
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46175685 |
|
This pull request has been merged in dfd445c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If a TM calls a completion callback, or resolves or rejects a promise multiple times, a C++ exception is thrown.
For an in the wild crash, we are getting this signal as:
libdispatchcalls std::terminate while pumping a thread's message queuelibdispatchtermination may be due to unhandled C++ exceptionI think if we change the time of
abort()to when the callback is called, we might be able to preserve the stack trace of module code calling the callback.Differential Revision: D46175685