-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BridgelessReactPackage to com.facebook.react package #37697
Conversation
This pull request was exported from Phabricator. Differential Revision: D46408934 |
…7697) Summary: Pull Request resolved: facebook#37697 Move BridgelessReactPackage to com.facebook.react package. This is necessary because BridgelessReactPackage is a core package that needs to be part of RN (and should not be re-defined by all apps) I will revisit naming in a later diff changelog: [internal] internal Reviewed By: cortinico, philIip Differential Revision: D46408934 fbshipit-source-id: f6b3f2564203e38008e6a2d5439dbb31782d4991
This pull request was exported from Phabricator. Differential Revision: D46408934 |
…7697) Summary: Pull Request resolved: facebook#37697 Move BridgelessReactPackage to com.facebook.react package. This is necessary because BridgelessReactPackage is a core package that needs to be part of RN (and should not be re-defined by all apps) I will revisit naming in a later diff changelog: [internal] internal Reviewed By: cortinico, philIip Differential Revision: D46408934 fbshipit-source-id: 65b51b293c8164bf5d0a443b3448b1d96d64050f
This pull request was exported from Phabricator. Differential Revision: D46408934 |
…tHost API Summary: This diff introduces the new generic class BoltsFutureTask<> that will be used by ReactHost to expose async task in its API. The goal of BoltsFutureTask is to avoid leadking the bolts.Task dependency into the ReactHost API. Public methods of this class follow the spec defined in the Future interface, see: https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/Future.html. I didn't add javadocs to avoid duplicated documentation with Future and also becuase this is private class. changelog: [internal] internal Differential Revision: D46170466 fbshipit-source-id: eaabb2def34a8a44d2cffd7c71acb0f203482818
Summary: In this diff I'm reducing visibility of RCTDeviceEventEmitter interface in ReactContext. This is an internal interface that has no usages externally (neither at Meta or github source) changelog: [internal] internal Differential Revision: D46241623 fbshipit-source-id: 1d43bac14f2222d3aed365ae62e534d4f5aa63b9
Summary: This diff reduces the visibility of ReactHost.destroy() method changelog: [internal] internal Differential Revision: D46293388 fbshipit-source-id: 04f2260827f399208a47c3d2b8ac27d8ef39ea43
Summary: Update documentation of ReactHost.reload method changelog: [internal] internal Differential Revision: D46293519 fbshipit-source-id: e68669c68222a6267baf33bff724424dbbaba17a
Summary: Rename ReactHost.preload -> ReactHost.start to adhere to stable api changelog: [internal] internal Differential Revision: D46294685 fbshipit-source-id: 1440772d19eb7dc84198cb09d357d652008213d8
Summary: In this diff I'm reducing visibility of NativeModule methods in ReactHost (from public to package) changelog: [internal] ineternal Differential Revision: D46296987 fbshipit-source-id: a470f69222a79b7c0682c08173fdd120046dd2b7
Summary: Fix lint warnings changelog: [internal] internal Differential Revision: D46407027 fbshipit-source-id: 0a27729008b73a5d752f19cffc7a495563faef66
…7697) Summary: Pull Request resolved: facebook#37697 Move BridgelessReactPackage to com.facebook.react package. This is necessary because BridgelessReactPackage is a core package that needs to be part of RN (and should not be re-defined by all apps) I will revisit naming in a later diff changelog: [internal] internal Reviewed By: cortinico, philIip Differential Revision: D46408934 fbshipit-source-id: fb8cfb8df7d575f46e4888d213e25f7edef3c798
This pull request was exported from Phabricator. Differential Revision: D46408934 |
This pull request has been merged in 3f7507b. |
This pull request has been reverted by 0c520e0. |
Summary:
Move BridgelessReactPackage to com.facebook.react package.
This is necessary because BridgelessReactPackage is a core package that needs to be part of RN (and should not be re-defined by all apps)
I will revisit naming in a later diff
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D46408934