Sync AnimatedValue JS node value when animation completes #37779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
genkikondo
force-pushed
the
export-D46498320
branch
from
1ea6521 to
7a38420
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46498320 |
Base commit: 7bcff07 |
|
This pull request was exported from Phabricator. Differential Revision: D46498320 |
genkikondo
force-pushed
the
export-D46498320
branch
from
7a38420 to
1c6a499
Compare
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
Jun 9, 2023
…7779) Summary: Pull Request resolved: facebook#37779 For natively driven animations, we now get the final value of the animation on JS side in the animation end callback. We sync this value into the JS-side AnimatedValue node. Changelog: [General][Changed] - Sync AnimatedValue JS node value when animation completes Differential Revision: D46498320 fbshipit-source-id: bde6141b78f1ab7d97103e8858db755de9f0abc3
…7779) Summary: Pull Request resolved: facebook#37779 For natively driven animations, we now get the final value of the animation on JS side in the animation end callback. We sync this value into the JS-side AnimatedValue node. Changelog: [General][Changed] - Sync AnimatedValue JS node value when animation completes Differential Revision: D46498320 fbshipit-source-id: d72f1bf411ad286fd6e0143a1088527ccc982840
|
This pull request was exported from Phabricator. Differential Revision: D46498320 |
genkikondo
force-pushed
the
export-D46498320
branch
from
1c6a499 to
e0bd36c
Compare
|
This pull request has been merged in 51cea49. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For natively driven animations, we now get the final value of the animation on JS side in the animation end callback. We sync this value into the JS-side AnimatedValue node.
Changelog:
[General][Changed] - Sync AnimatedValue JS node value when animation completes
Differential Revision: D46498320