introduce RCTTestUtils #37810
Closed
introduce RCTTestUtils #37810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46507803 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 9, 2023
Summary: Pull Request resolved: facebook#37810 Changelog: [Internal] in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a `rn_xplat_cxx_library`. this file is also not obj-c++, so i feel like we should decouple if possible. it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing. Reviewed By: cipolleschi Differential Revision: D46507803 fbshipit-source-id: afff16d12093805856ae8ded8919e382d58094e9
|
This pull request was exported from Phabricator. Differential Revision: D46507803 |
Base commit: 7d1f7f3 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 9, 2023
Summary: Pull Request resolved: facebook#37810 Changelog: [Internal] in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a `rn_xplat_cxx_library`. this file is also not obj-c++, so i feel like we should decouple if possible. it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing. Reviewed By: cipolleschi Differential Revision: D46507803 fbshipit-source-id: 70fa17e29499c6c00526c23ed5e583c3e2c7aa1e
|
This pull request was exported from Phabricator. Differential Revision: D46507803 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 11, 2023
Summary: Pull Request resolved: facebook#37810 Changelog: [Internal] in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a `rn_xplat_cxx_library`. this file is also not obj-c++, so i feel like we should decouple if possible. it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing. Reviewed By: cipolleschi Differential Revision: D46507803 fbshipit-source-id: a9657a636ce6f97b0f84ec29f0b8944bc0181409
philIip
force-pushed
the
export-D46507803
branch
from
bf83622 to
01ab2c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46507803 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 11, 2023
Summary: Pull Request resolved: facebook#37810 Changelog: [Internal] in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a `rn_xplat_cxx_library`. this file is also not obj-c++, so i feel like we should decouple if possible. it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing. Reviewed By: cipolleschi Differential Revision: D46507803 fbshipit-source-id: cef443c56bb705c5ef5f17a4cdaff75e46d34d54
philIip
force-pushed
the
export-D46507803
branch
from
01ab2c0 to
e68b621
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46507803 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 11, 2023
Summary: Pull Request resolved: facebook#37810 Changelog: [Internal] in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a `rn_xplat_cxx_library`. this file is also not obj-c++, so i feel like we should decouple if possible. it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing. Reviewed By: cipolleschi Differential Revision: D46507803 fbshipit-source-id: 79bca0ab853ce060ff90d633d2f6e070f72b6179
philIip
force-pushed
the
export-D46507803
branch
from
e68b621 to
3c96787
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46507803 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 12, 2023
Summary: Pull Request resolved: facebook#37810 Changelog: [Internal] in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a `rn_xplat_cxx_library`. this file is also not obj-c++, so i feel like we should decouple if possible. it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing. Reviewed By: cipolleschi Differential Revision: D46507803 fbshipit-source-id: b042feed2592fcf00bd5338ce3ae4a9c2ca2d191
philIip
force-pushed
the
export-D46507803
branch
from
3c96787 to
1da8b0a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46507803 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Jun 12, 2023
Summary: Pull Request resolved: facebook#37810 Changelog: [Internal] in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a `rn_xplat_cxx_library`. this file is also not obj-c++, so i feel like we should decouple if possible. it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing. Reviewed By: cipolleschi Differential Revision: D46507803 fbshipit-source-id: 9e3e56c412f1c7725c2855e5b8ded7119044e0c9
philIip
force-pushed
the
export-D46507803
branch
from
1da8b0a to
4bd3941
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46507803 |
Differential Revision: D46467041 fbshipit-source-id: 27ce5c24fd541b1380ed2fadc7d748bf64bd1fed
Differential Revision: D46467229 fbshipit-source-id: 84fd40219855b1dbe0a6bdb021b9b41a5b9efa7f
Summary: Pull Request resolved: facebook#37810 Changelog: [Internal] in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a `rn_xplat_cxx_library`. this file is also not obj-c++, so i feel like we should decouple if possible. it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing. Reviewed By: cipolleschi Differential Revision: D46507803 fbshipit-source-id: 16e8dad7abf30963aa61642b0f2764bcc5204003
philIip
force-pushed
the
export-D46507803
branch
from
4bd3941 to
af4b710
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46507803 |
|
This pull request has been merged in a300a35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
in this change, i introduce a helper file for swizzling selectors that can be used for building custom shims and fakes. i tried putting this in the cxx target, but i struggled a lot with managing the dependencies and understanding the extra behavior that was happening from being in a
rn_xplat_cxx_library. this file is also not obj-c++, so i feel like we should decouple if possible.it does seem like this is a new practice i'm introducing, so let me know if there's something that i'm missing.
Reviewed By: cipolleschi
Differential Revision: D46507803