Fix Android border clip check #37828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 03f70bf |
kelset
approved these changes
Jun 12, 2023
kelset
reviewed
Jun 12, 2023
Comment on lines
+572
to
+581
| if (isBorderColorDefined(Spacing.BLOCK)) { | ||
| colorBottom = colorBlock; | ||
| colorTop = colorBlock; | ||
| } | ||
| if (isBorderColorDefined(Spacing.BLOCK_END)) { | ||
| colorBottom = colorBlockEnd; | ||
| } | ||
| if (isBorderColorDefined(Spacing.BLOCK_START)) { | ||
| colorTop = colorBlockStart; | ||
| } |
There was a problem hiding this comment.
small nit and def not to address in this PR given the urgency - but this section of the code is repeated 3 times as far as I can see in this file (at L366, L575, L1171), we should look into dedup.
kelset
changed the title
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 7d1f7f3. |
kelset
pushed a commit
that referenced
this pull request
Jun 13, 2023
Summary: Instead of requiring all types of border color values to be present we should only take into consideration the left, top, right, bottom, and allEdges values and inject block values into colorBottom and colorTop. This PR only addresses the first issue described here (#37753 (comment)) by kelset ## Changelog: [ANDROID] [FIXED] - Fix border clip check Pull Request resolved: #37828 Test Plan: Test through rn-tester if border color is being applied <img width="482" alt="image" src="https://github.com/facebook/react-native/assets/11707729/c8c8772c-da8d-4393-bc3f-5868eca5df15"> Reviewed By: lunaleaps Differential Revision: D46643773 Pulled By: cipolleschi fbshipit-source-id: efb1ea81bf2462c14767a2554880eb7c44989975
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 15, 2023
Summary: Instead of requiring all types of border color values to be present we should only take into consideration the left, top, right, bottom, and allEdges values and inject block values into colorBottom and colorTop. This PR only addresses the first issue described here (facebook#37753 (comment)) by kelset ## Changelog: [ANDROID] [FIXED] - Fix border clip check Pull Request resolved: facebook#37828 Test Plan: Test through rn-tester if border color is being applied <img width="482" alt="image" src="https://github.com/facebook/react-native/assets/11707729/c8c8772c-da8d-4393-bc3f-5868eca5df15"> Reviewed By: lunaleaps Differential Revision: D46643773 Pulled By: cipolleschi fbshipit-source-id: efb1ea81bf2462c14767a2554880eb7c44989975 (cherry picked from commit 2d15f50)
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of requiring all types of border color values to be present we should only take into consideration the left, top, right, bottom, and allEdges values and inject block values into colorBottom and colorTop.
This PR only addresses the first issue described here (#37753 (comment)) by @kelset
Changelog:
[ANDROID] [FIXED] - Fix border clip check
Test Plan:
Test through rn-tester if border color is being applied