fix(virtualized-lists): react-test-renderer is not a runtime dependency
#37955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
following up from what was discussed in the releases weekly sync, this one might require a 0.72.1 soon after 0.72.0. Let's merge it asap pls |
|
/rebase |
github-actions
bot
force-pushed
the
tido/remove-unused-peer-dep
branch
from
293505b to
e78a3bc
Compare
Base commit: cba13bb |
|
This LGTM. I can import once I’m in the office. |
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @tido64 in 7a2a327. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Jun 28, 2023
…ency (#37955) Summary: Installing `react-native` 0.72.x causes a warning about `react-test-renderer` because `react-native/virtualized-lists` has declared a peer dependency on it. As far as I know, it is not used for anything but tests. ``` ➤ YN0002: │ react-native@npm:0.72.0-rc.6 [292eb] doesn't provide react-test-renderer (p5a2fb), requested by react-native/virtualized-lists ``` Note that while many package managers default to warnings in this case, there are still a number of users out there for which this is an error. ## Changelog: [GENERAL] [FIXED] - `react-native/virtualized-lists` does not need `react-test-renderer` at runtime Pull Request resolved: #37955 Test Plan: n/a Reviewed By: rshest Differential Revision: D46871536 Pulled By: NickGerleman fbshipit-source-id: 1e5e15608ab394bc43cd4e6ac727a74734874642
This was referenced Aug 10, 2023
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Sep 5, 2023
…ency (facebook#37955) Summary: Installing `react-native` 0.72.x causes a warning about `react-test-renderer` because `react-native/virtualized-lists` has declared a peer dependency on it. As far as I know, it is not used for anything but tests. ``` ➤ YN0002: │ react-native@npm:0.72.0-rc.6 [292eb] doesn't provide react-test-renderer (p5a2fb), requested by react-native/virtualized-lists ``` Note that while many package managers default to warnings in this case, there are still a number of users out there for which this is an error. [GENERAL] [FIXED] - `react-native/virtualized-lists` does not need `react-test-renderer` at runtime Pull Request resolved: facebook#37955 Test Plan: n/a Reviewed By: rshest Differential Revision: D46871536 Pulled By: NickGerleman fbshipit-source-id: 1e5e15608ab394bc43cd4e6ac727a74734874642
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Sep 5, 2023
…ency (facebook#37955) Summary: Installing `react-native` 0.72.x causes a warning about `react-test-renderer` because `react-native/virtualized-lists` has declared a peer dependency on it. As far as I know, it is not used for anything but tests. ``` ➤ YN0002: │ react-native@npm:0.72.0-rc.6 [292eb] doesn't provide react-test-renderer (p5a2fb), requested by react-native/virtualized-lists ``` Note that while many package managers default to warnings in this case, there are still a number of users out there for which this is an error. [GENERAL] [FIXED] - `react-native/virtualized-lists` does not need `react-test-renderer` at runtime Pull Request resolved: facebook#37955 Test Plan: n/a Reviewed By: rshest Differential Revision: D46871536 Pulled By: NickGerleman fbshipit-source-id: 1e5e15608ab394bc43cd4e6ac727a74734874642
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Installing
react-native0.72.x causes a warning aboutreact-test-rendererbecause@react-native/virtualized-listshas declared a peer dependency on it. As far as I know, it is not used for anything but tests.Note that while many package managers default to warnings in this case, there are still a number of users out there for which this is an error.
Changelog:
[GENERAL] [FIXED] -
@react-native/virtualized-listsdoes not needreact-test-rendererat runtimeTest Plan:
n/a