Expose react_utils via prefab to fix broken test_android #37965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46841689 |
Base commit: af57ce1 |
) Summary: Pull Request resolved: facebook#37965 test_android is currently failing as we're not shipping the implementation of one of the symbol inside `react_utils` which is now accessed by the `ConcreteComponentDescriptor.h` file (used by the app project). Either we expose `react_utils` as a static library (.a) or as a dynamic library (.so). I've decided to go for the latter for the sake of saving space on user devices. Changelog: [Internal] [Changed] - Expose react_utils via prefab to fix broken test_android Reviewed By: sammy-SC Differential Revision: D46841689 fbshipit-source-id: 9600c712acf36303aef2f525f11a02056424546c
cortinico
force-pushed
the
export-D46841689
branch
from
c9d7d39 to
0f017cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46841689 |
|
This pull request has been merged in 9101e44. |
yayvery
pushed a commit
to discord/react-native
that referenced
this pull request
Jan 14, 2024
) Summary: Pull Request resolved: facebook#37965 test_android is currently failing as we're not shipping the implementation of one of the symbol inside `react_utils` which is now accessed by the `ConcreteComponentDescriptor.h` file (used by the app project). Either we expose `react_utils` as a static library (.a) or as a dynamic library (.so). I've decided to go for the latter for the sake of saving space on user devices. Changelog: [Internal] [Changed] - Expose react_utils via prefab to fix broken test_android Reviewed By: sammy-SC Differential Revision: D46841689 fbshipit-source-id: a5467ca3a7ac2f26f7a5a2c4d6e161a391766b0d
yayvery
pushed a commit
to discord/react-native
that referenced
this pull request
Jan 14, 2024
) Summary: Pull Request resolved: facebook#37965 test_android is currently failing as we're not shipping the implementation of one of the symbol inside `react_utils` which is now accessed by the `ConcreteComponentDescriptor.h` file (used by the app project). Either we expose `react_utils` as a static library (.a) or as a dynamic library (.so). I've decided to go for the latter for the sake of saving space on user devices. Changelog: [Internal] [Changed] - Expose react_utils via prefab to fix broken test_android Reviewed By: sammy-SC Differential Revision: D46841689 fbshipit-source-id: a5467ca3a7ac2f26f7a5a2c4d6e161a391766b0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
test_android is currently failing as we're not shipping the implementation of one of the symbol inside
react_utilswhich is now accessed by the
ConcreteComponentDescriptor.hfile (used by the app project).Either we expose
react_utilsas a static library (.a) or as a dynamic library (.so). I've decided to go for the latterfor the sake of saving space on user devices.
Changelog:
[Internal] [Changed] - Expose react_utils via prefab to fix broken test_android
Differential Revision: D46841689