Use vals inside ReactApplication #38088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47053030 |
4 tasks
Base commit: a4a0655 |
|
This pull request was exported from Phabricator. Differential Revision: D47053030 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 27, 2023
Summary: Pull Request resolved: facebook#38088 For better Kotlin interop we should be using `val` in this interface rather than just `fun`. This is not a breaking change as Java users can still use `getReactNativeHost()` as before. Changelog: [Internal] [Changed] - Use vals inside ReactApplication Reviewed By: javache Differential Revision: D47053030 fbshipit-source-id: 28ced59e59fa4ac51f4b9a94103678fa1787e34a
cortinico
force-pushed
the
export-D47053030
branch
from
1b49e15 to
f9f5391
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47053030 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 27, 2023
Summary: Pull Request resolved: facebook#38088 For better Kotlin interop we should be using `val` in this interface rather than just `fun`. This is not a breaking change as Java users can still use `getReactNativeHost()` as before. Changelog: [Internal] [Changed] - Use vals inside ReactApplication Reviewed By: javache Differential Revision: D47053030 fbshipit-source-id: 86e1e9c9528e94e8e179c36f2e15edda3aec5305
cortinico
force-pushed
the
export-D47053030
branch
2 times, most recently
from
cadee57 to
6444380
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 29, 2023
Summary: Pull Request resolved: facebook#38088 For better Kotlin interop we should be using `val` in this interface rather than just `fun`. This is not a breaking change as Java users can still use `getReactNativeHost()` as before. Changelog: [Internal] [Changed] - Use vals inside ReactApplication Reviewed By: javache Differential Revision: D47053030 fbshipit-source-id: 2bac360060244003aa2ed44c2b151d4aebeea86c
|
This pull request was exported from Phabricator. Differential Revision: D47053030 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47053030 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 30, 2023
Summary: Pull Request resolved: facebook#38088 For better Kotlin interop we should be using `val` in this interface rather than just `fun`. This is not a breaking change as Java users can still use `getReactNativeHost()` as before. Changelog: [Internal] [Changed] - Use vals inside ReactApplication Reviewed By: javache Differential Revision: D47053030 fbshipit-source-id: a54efec91e7476e1084db495bfdeff6700c347ce
cortinico
force-pushed
the
export-D47053030
branch
from
6444380 to
e96d460
Compare
Summary: Pull Request resolved: facebook#38088 For better Kotlin interop we should be using `val` in this interface rather than just `fun`. This is not a breaking change as Java users can still use `getReactNativeHost()` as before. Changelog: [Internal] [Changed] - Use vals inside ReactApplication Reviewed By: javache Differential Revision: D47053030 fbshipit-source-id: 5f5e204efc490b214408d5c715b49b6a51508584
cortinico
force-pushed
the
export-D47053030
branch
from
e96d460 to
011fe9d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47053030 |
|
This pull request was successfully merged by @cortinico in c3f672c. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in c3f672c. |
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Pull Request resolved: facebook/react-native#38088 For better Kotlin interop we should be using `val` in this interface rather than just `fun`. This is not a breaking change as Java users can still use `getReactNativeHost()` as before. Changelog: [Internal] [Changed] - Use vals inside ReactApplication Reviewed By: javache Differential Revision: D47053030 fbshipit-source-id: 4a7fbc71a76be54e1cf7daef499b9bc3e8fc615a Original: facebook/react-native@c3f672c
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#38088 For better Kotlin interop we should be using `val` in this interface rather than just `fun`. This is not a breaking change as Java users can still use `getReactNativeHost()` as before. Changelog: [Internal] [Changed] - Use vals inside ReactApplication Reviewed By: javache Differential Revision: D47053030 fbshipit-source-id: 4a7fbc71a76be54e1cf7daef499b9bc3e8fc615a Original-Commit: facebook/react-native@c3f672c
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#38088 For better Kotlin interop we should be using `val` in this interface rather than just `fun`. This is not a breaking change as Java users can still use `getReactNativeHost()` as before. Changelog: [Internal] [Changed] - Use vals inside ReactApplication Reviewed By: javache Differential Revision: D47053030 fbshipit-source-id: 4a7fbc71a76be54e1cf7daef499b9bc3e8fc615a Original-Commit: facebook/react-native@c3f672c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For better Kotlin interop we should be using
valin this interface rather than justfun.This is not a breaking change as Java users can still use
getReactNativeHost()as before.Changelog:
[Internal] [Changed] - Use vals inside ReactApplication
Differential Revision: D47053030