Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create RuntimeExecutor on non-JSI executors #38125

Closed
wants to merge 1 commit into from

Conversation

javache
Copy link
Member

@javache javache commented Jun 29, 2023

Summary:
On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a jsi::Runtime from JSExecutor.

Changelog: [General][Fixed] Android does't crash when using remote debugger

Differential Revision: D47124234

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 29, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47124234

@analysis-bot
Copy link

analysis-bot commented Jun 29, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,047,242 +14
android hermes armeabi-v7a 8,296,530 +35
android hermes x86 9,563,413 +37
android hermes x86_64 9,405,704 -17
android jsc arm64-v8a 9,606,267 +5
android jsc armeabi-v7a 8,732,992 +33
android jsc x86 9,693,306 +17
android jsc x86_64 9,939,600 -27

Base commit: 3a912a3
Branch: main

javache added a commit to javache/react-native that referenced this pull request Jun 30, 2023
Summary:
Pull Request resolved: facebook#38125

On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`.

Changelog: [General][Fixed] Android does't crash when using remote debugger

Reviewed By: NickGerleman

Differential Revision: D47124234

fbshipit-source-id: b63d9eb5f1d7410f8150340dcd226e9317a2bfdc
@javache javache force-pushed the export-D47124234 branch from 1e65f84 to d5902a9 Compare June 30, 2023 10:41
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47124234

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47124234

javache added a commit to javache/react-native that referenced this pull request Jun 30, 2023
Summary:
Pull Request resolved: facebook#38125

On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`.

Changelog: [General][Fixed] Android does't crash when using remote debugger

Reviewed By: NickGerleman

Differential Revision: D47124234

fbshipit-source-id: c178915af327604d12c48b1b472ad624a7b75e94
@javache javache force-pushed the export-D47124234 branch from d5902a9 to 3078097 Compare June 30, 2023 12:12
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47124234

javache added a commit to javache/react-native that referenced this pull request Jun 30, 2023
Summary:
Pull Request resolved: facebook#38125

On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`.

Changelog: [General][Fixed] Android does't crash when using remote debugger

Reviewed By: NickGerleman

Differential Revision: D47124234

fbshipit-source-id: 45ccc2544f104223efde1bec44e11b9cdfc1de52
@javache javache force-pushed the export-D47124234 branch from 3078097 to 1dedc83 Compare June 30, 2023 12:20
Summary:
Pull Request resolved: facebook#38125

On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`.

Changelog: [General][Fixed] Android does't crash when using remote debugger

Reviewed By: NickGerleman

Differential Revision: D47124234

fbshipit-source-id: d6e93c760174361940d53fe8c2ebf4685d8cf8ae
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47124234

@javache javache force-pushed the export-D47124234 branch from 1dedc83 to a34c48f Compare June 30, 2023 13:04
@github-actions
Copy link

This pull request was successfully merged by @javache in 0fe5ffd.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Jun 30, 2023
lunaleaps pushed a commit to lunaleaps/react-native that referenced this pull request Jun 30, 2023
Summary:
Pull Request resolved: facebook#38125

On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`.

Changelog: [General][Fixed] Android does't crash when using remote debugger

Reviewed By: NickGerleman

Differential Revision: D47124234

fbshipit-source-id: 0542da1aca5d411964e3a0833f4c48428ed90c91
@javache javache deleted the export-D47124234 branch July 3, 2023 14:23
AshlandWest referenced this pull request in Salt-PepperEngineering/react-native-nordic-dfu Jul 7, 2023
kelset pushed a commit that referenced this pull request Jul 10, 2023
Co-authored-by: Pieter De Baets <pieterdb@meta.com>
resolved: #38125
Kudo pushed a commit to expo/react-native that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants