Add global hook to assert that base Metro config is called #38126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47125080 |
…38126) Summary: Pull Request resolved: facebook#38126 Towards react-native-community/cli#1987. Will be paired with a CLI PR targeting React Native 0.72.1. Changelog: None Reviewed By: motiz88 Differential Revision: D47125080 fbshipit-source-id: 9c5eb9ed791ace7a1314ebc26e4dcf494cf190e1
Base commit: 0bd6b28 |
|
This pull request was exported from Phabricator. Differential Revision: D47125080 |
|
This pull request was successfully merged by @huntie in 29f2602. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Jul 10, 2023
Summary: Pull Request resolved: #38126 Towards react-native-community/cli#1987. Will be paired with a CLI PR targeting React Native 0.72.1. Changelog: None Reviewed By: motiz88 Differential Revision: D47125080 fbshipit-source-id: b3b9d93ba747240f5168021ccb793ffe5d34251d
This was referenced Aug 1, 2023
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Towards react-native-community/cli#1987. Will be paired with a CLI PR targeting React Native 0.72.1.
A global hook is the more lenient of the options considered to handle this — notably it will allow the CLI
startcommand to continue when we may have mismatched versions of@react-native/metro-config.Changelog: None
Differential Revision: D47125080