Disable nstextstorage_caching in OSS #38129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47127912 |
Base commit: 80a2b8e |
Differential Revision: D47127817 fbshipit-source-id: b7165610ce9d10d7646cbf843dc01c705bc10b6c
Summary: Pull Request resolved: facebook#38129 changelog: [iOS] Disable NSTextStorage caching in OSS A [bug was reported](facebook#37944) for NSTextStorage caching. Even thought I fixed the bug in D47019250, I want to disable the feature in OSS until the fix is verified in Facebook app. My plan is to pick this commit for 0.72.1 and reenable NSTextStorage caching once the fix is validated. Reviewed By: NickGerleman Differential Revision: D47127912 fbshipit-source-id: 76d94e6e4c14a989765212faff57c78d91f176ee
|
This pull request was exported from Phabricator. Differential Revision: D47127912 |
sammy-SC
force-pushed
the
export-D47127912
branch
from
e79832e
to
d12f9c3
Compare
|
This pull request was successfully merged by @sammy-SC in 5bda54c. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Jul 10, 2023
Summary: Pull Request resolved: #38129 changelog: [iOS] Disable NSTextStorage caching in OSS A [bug was reported](#37944) for NSTextStorage caching. Even thought I fixed the bug in D47019250, I want to disable the feature in OSS until the fix is verified in Facebook app. My plan is to pick this commit for 0.72.1 and reenable NSTextStorage caching once the fix is validated. Reviewed By: NickGerleman Differential Revision: D47127912 fbshipit-source-id: 97694e383eb751e89b776c0599969f2c411bac6f
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 11, 2023
Summary: Pull Request resolved: facebook#38129 changelog: [iOS] Disable NSTextStorage caching in OSS A [bug was reported](facebook#37944) for NSTextStorage caching. Even thought I fixed the bug in D47019250, I want to disable the feature in OSS until the fix is verified in Facebook app. My plan is to pick this commit for 0.72.1 and reenable NSTextStorage caching once the fix is validated. Reviewed By: NickGerleman Differential Revision: D47127912 fbshipit-source-id: 97694e383eb751e89b776c0599969f2c411bac6f
This was referenced Aug 1, 2023
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [iOS] Disable NSTextStorage caching in OSS
A bug was reported for NSTextStorage caching. Even thought I fixed the bug in D47019250, I want to disable the feature in OSS until the fix is verified in Facebook app.
My plan is to pick this commit for 0.72.1 and reenable NSTextStorage caching once the fix is validated.
Differential Revision: D47127912