Fix build failure on iOS with pnpm and use_frameworks!

[evelant]

Summary:

Fix build failure on iOS with pnpm and use_frameworks! due to cocoapods copying symlinked headers to wrong paths

When using pnpm all packages are symlinked to node_modules/.pnpm to prevent phantom dependency resolution. This causes react-native iOS build to fail because Cocoapods copies headers to incorrect destinations when they're behind symlinks. The fix resolves absolute paths to the header_mappings_dir at pod install time. With absolute paths cocoapods copies the headers correctly.

This commit also adds a few missing header search paths in use_frameworks! mode.

Fixes #38140

Changelog:

Test Plan:

1. pnpm pnpx react-native@latest init AwesomeProject
2. cd AwesomeProject
3. rm -rf node_modules yarn.lock
4. mkdir patches
5. copy react-native@0.72.1.patch to patches/
6. Add patch to package.json

"pnpm": {
    "patchedDependencies": {
        "react-native@0.72.1": "patches/react-native@0.72.1.patch"
    }
}

7. pnpm install
8. cd ios
9. NO_FLIPPER=1 USE_FRAMEWORKS=static pod install
10. cd ..
11. pnpm react-native run-ios

Hopefully an automated test of building with pnpm can be added to CI. I don't know how to make that happen, hopefully someone at facebook can do it.

[facebook-github-bot]

Hi @evelant!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,047,499	-5
android	hermes	armeabi-v7a	8,296,920	-3
android	hermes	x86	9,563,791	-3
android	hermes	x86_64	9,405,946	-6
android	jsc	arm64-v8a	9,606,213	-7
android	jsc	armeabi-v7a	8,732,931	-3
android	jsc	x86	9,693,257	-5
android	jsc	x86_64	9,939,541	-4

Base commit: 971bb81
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[cipolleschi]

Hi there, thank you so much for taking the time of fixing this!

Before importing and merging this, we need to make sure that CI is green again.
I left a couple of questions and suggestions to improve the solution.

Could you give them a shot?

[cipolleschi]

What is generating code inside these folders? The default setup for Codegen does not do that.

[evelant]

I'm actually not sure, that's a react-native iOS build detail beyond my understanding.

To make this patch I repeatedly compiled the simple reproduction here https://github.com/evelant/rn072-ios-frameworks-static-failure and noted which pod and headers it was failing on each time. I located the missing header files in the build output and added those locations to the search path.

After repeating the above enough times all the headers resolved correctly and the project compiled successfully.

[evelant]

Actually I think it's due to this line https://github.com/facebook/react-native/pull/38158/files#diff-c09e8b79ee60d74ca03bb3960e11fd2155e2391451933b8f6d008a56dfac4e3cR40

When cocoapods copies the headers using the full path for header_mappings_dir this is where they end up.

[cipolleschi]

Hopefully an automated test of building with pnpm can be added to CI. I don't know how to make that happen, hopefully someone at facebook can do it.

This would be great. I have the knowledge of how to set up the CI, but no knowledge on how to run pnpm. 😝
What is required to set up a simple app with pnpm?

[evelant]

@cipolleschi Just the instructions on the reproduction above. pnpm is a drop in replacement for yarn or npm. Create a react-native app, remove package-lock.json or yarn.lock, then run pnpm install and that's it.

[evelant]

Sorry about that, somehow my patch didn't get fully applied when I made the commit for this PR. I've fixed it now.

[cipolleschi]

@cipolleschi Just the instructions on the reproduction above. pnpm is a drop in replacement for yarn or npm. Create a react-native app, remove package-lock.json or yarn.lock, then run pnpm install and that's it.

I understand... I'm not sure that package is available on CircleCI. How do you install pnpm the first time?

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[evelant]

@cipolleschi Just the instructions on the reproduction above. pnpm is a drop in replacement for yarn or npm. Create a react-native app, remove package-lock.json or yarn.lock, then run pnpm install and that's it.

I understand... I'm not sure that package is available on CircleCI. How do you install pnpm the first time?

npm install -g pnpm is the easiest

There are a number of other install methods if they might be more appropriate for CI https://pnpm.io/installation

[github-actions]

This pull request was successfully merged by evelant in 58adc5e.

^{When will my fix make it into a release? | Upcoming Releases}