Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: iOS <TextInput multiline/> onChangeText does not fire if only one character #38166

Closed
wants to merge 1 commit into from

Conversation

aroravarun
Copy link

Summary:

This change fixes #38105

Changelog:

Pick one each for the category and type tags:

[IOS] [FIXED] - Fix for #38105

Test Plan:

Screen.Recording.2023-07-03.at.23.13.23_compressed.mp4

@facebook-github-bot
Copy link
Contributor

Hi @aroravarun!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,047,498 -953
android hermes armeabi-v7a 8,296,921 -945
android hermes x86 9,563,792 -954
android hermes x86_64 9,405,947 -958
android jsc arm64-v8a 9,606,214 -612
android jsc armeabi-v7a 8,732,934 -612
android jsc x86 9,693,257 -610
android jsc x86_64 9,939,542 -615

Base commit: 2910f87
Branch: main

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@efstathiosntonas
Copy link

efstathiosntonas commented Jul 4, 2023

@aroravarun are there any conflicts with this PR? #37958

@cortinico cortinico changed the title Fix: 38105 Fix: iOS <TextInput multiline/> onChangeText does not fire if only one character Jul 4, 2023
@aroravarun aroravarun closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS <TextInput multiline/> onChangeText does not fire if only one character
4 participants