Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore more files/packages by default in LogBox #38217

Closed
wants to merge 1 commit into from

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented Jul 6, 2023

Summary:
Marks more filename patterns as "internal call sites" which has the effect of collapsing them by default in LogBox (and skipping them for the purpose of providing a code frame).

Changelog: [General][Fixed] Hide Babel helpers and other core files from LogBox stack traces by default

Differential Revision: D47230876

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jul 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47230876

@analysis-bot
Copy link

analysis-bot commented Jul 6, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,000,302 -1
android hermes armeabi-v7a 8,254,395 +1
android hermes x86 9,509,460 +4
android hermes x86_64 9,355,199 +2
android jsc arm64-v8a 9,613,651 +3
android jsc armeabi-v7a 8,740,276 +4
android jsc x86 9,700,609 +2
android jsc x86_64 9,947,161 +4

Base commit: f6c91bf
Branch: main

Summary:
Pull Request resolved: facebook#38217

Marks more filename patterns as "internal call sites" which has the effect of collapsing them by default in LogBox (and skipping them for the purpose of providing a code frame).

Changelog: [General][Fixed] Hide Babel helpers and other core files from LogBox stack traces by default

Reviewed By: cortinico, huntie

Differential Revision: D47230876

fbshipit-source-id: 89f81d56124cb0fb4695f27b4cb32bbe3fc2a082
@motiz88 motiz88 force-pushed the export-D47230876 branch from e52eb9e to e36e0ac Compare July 6, 2023 15:22
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47230876

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in af73a75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants