Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Paper - old arch) #38258

Closed
wants to merge 6 commits into from
Closed

Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Paper - old arch) #38258

wants to merge 6 commits into from

Commits on Jul 8, 2023

  1. avoid changing Text baseline

    @fabOnReact
    fabOnReact committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    68d795f View commit details
    Browse the repository at this point in the history

  2. remove logic that over-rides Text lineHeight when fontSize.lineHeight… 

    … > lineHeight
    @fabOnReact
    fabOnReact committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    e2b615a View commit details
    Browse the repository at this point in the history

  3. check for nan

    @fabOnReact
    fabOnReact committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    d9ef348 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Test lineHeight lower then fontSize.lineHeight

    @fabOnReact
    fabOnReact committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    84d7d14 View commit details
    Browse the repository at this point in the history

  2. adding comments

    @fabOnReact
    fabOnReact committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    0adeebb View commit details
    Browse the repository at this point in the history

  3. fix internal FB linter issue 

    The diff would trigger linter error internal in Facebook. I compared
the commit and the original diff and I was able to identify the linter
issue. I fixed the linter issue to avoid again failures when importing
it.

Comment
facebook#37465 (comment)

Imported in Facebook
facebook@35a1648#diff-08824b4f7ca9c31bd2a7aeb8b1180bd55b2b834d99667861e14e59082d06c137R179-R190

Original Diff
facebook@c4996fc#diff-08824b4f7ca9c31bd2a7aeb8b1180bd55b2b834d99667861e14e59082d06c137R170-R177
    @fabOnReact
    fabOnReact committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    b2e83de View commit details
    Browse the repository at this point in the history