Gate Platform.isTesting via __DEV__ on the native level #38339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47438069 |
Base commit: 4048317 |
Summary: Pull Request resolved: facebook#38339 ## Changelog: [Internal] - In D13050583, the `Platform.isTesting` was unconditionally forced to `false` in `__DEV__` on JS side. On some platforms, we may want to run tests in the release mode. This hoists these gatings down to the corresponding platforms' native modules. Reviewed By: ryancat Differential Revision: D47438069 fbshipit-source-id: ae1c7b55827406e20ac2f3fc6be194613c5c4ec7
|
This pull request was exported from Phabricator. Differential Revision: D47438069 |
|
This pull request has been merged in ecb58a1. |
juniorklawa
pushed a commit
to juniorklawa/react-native
that referenced
this pull request
Jul 20, 2023
Summary: Pull Request resolved: facebook#38339 ## Changelog: [Internal] - In D13050583, the `Platform.isTesting` was unconditionally forced to `false` in `__DEV__` on JS side. On some platforms, we may want to run tests in the release mode. This hoists these gatings down to the corresponding platforms' native modules. Reviewed By: ryancat Differential Revision: D47438069 fbshipit-source-id: 5bae3df9873f659f65179df93e727108d0062047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
In D13050583, the
Platform.isTestingwas unconditionally forced tofalsein__DEV__on JS side.On some platforms, we may want to run tests in the release mode.
This hoists these gatings down to the corresponding platforms' native modules.
Differential Revision: D47438069