Create option for out-of-tree platforms to customize View traits #38580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 25, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: 9651860fc3fa2fcbaa508e28836c68f5f6636460
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 25, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: ba6696773a5a6e63df8cd549505a9ae7b8925319
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 25, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: fbdc04b9d012a313dcb3ae23f1a0af5b8c1cdbce
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 25, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: c1727596977743603b9422c68018397af3e24279
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 26, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: d00717ad30db1aaef37f55df2b4bcea019980d25
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 26, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: 1eeab5f847fb1813172d0ff0fad4182fcdd2cf21
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 26, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: 258207d9067ab01e11a9143ae76d7e42b262cd26
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 26, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: f77fcd3bb2da69444c2167834c4f4f345b53bf91
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 29, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 29166d917e36472fb527e3e5bad07d9b974e0b95
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: f6a34517a13e2050bdc38f8552230747c6ceb792
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: 60d8c09229c8643210b651012d9dd76fceaa09c0
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 79689f6760e667eece729a093b3e651aa19790bd
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: b150be094d33f0c1a89e9252b6e2e887fdf92eed
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: f3317ed323a93be3e3346109b86a340d4d07753b
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 868a1a38d9d32196314a39096342affb5ae4ef85
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 4817e07a076f11969f5007149108424e530cf6c0
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 7ba77a294e80a50e701e81ec0f971141011975b1
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: b2025ff01090bb2587f3383189b952c9c34b1bb4
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 7d37a16aa7744e5068dbfba4bb0b61af0495149e
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 9fde734e019698ed30c3e594dd82e2864c66fdb7
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: c64d5623c972186a90be3246249fb20b1892410f
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: 7a389a007d57ebe277227fbfc1d443879edfb2fc
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
Summary: Pull Request resolved: facebook#38549 Out of tree platforms may need different implementations of ViewProps. In fact, Android does already with props like `needsOffscreenAlphaCompositing` and `focusable`. This diff is not opinionated on whether these props should actually be shared on all platforms. Props like `focusable` may be a good candidate for generalizing to all platforms. However, there will always be a need for one platform to experiment with a new prop while it's not available yet on another, especially when considering out of tree platforms. This diff moves the existing ViewProps class to BaseViewProps, aliases ViewProps as BaseViewProps for iOS for now, and moves Android-specific view props to it's own header and implementation. ## Changelog: [General] [Added] - Support additional View props in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47492635 fbshipit-source-id: 7240d257344a3eb62b7be55ff916a67a8256c796
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Reviewed By: christophpurrer Differential Revision: D47721377 fbshipit-source-id: 5efe5eb4d194f6d229ac77a0478330ddf539f7f8
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 02abc51bca3211426b6ad03827ab4b8fc97729b0
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 39dab5c7d66617ad5fc922b7f8504dced18ebe4a
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 5806c9629daa2ec361dc51cf694cdabea43d7bb9
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jul 31, 2023
…ebook#38580) Summary: Pull Request resolved: facebook#38580 We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors. This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors. ## Changelog: [General] [Added] - Support customization of View traits for flattening in out of tree platform Fabric implementations Differential Revision: https://internalfb.com/D47721377 fbshipit-source-id: 87c7ce5fcfc7dbe3440868c8ed19bffd47c7ebb7
|
This pull request was exported from Phabricator. Differential Revision: D47721377 |
|
This pull request has been merged in 646c759. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We already have a differential between Android and iOS View props that force view flattening (or unflattening) behaviors. Other out-of-tree platforms may have a need to customize view flattening behaviors.
This change adds a ViewTraitsInitializer header that out of tree platforms can inject to include platform-specific ViewProps fields when considering view flattening behaviors.
Differential Revision: D47721377