Back out "RN: Adopt Mapped Types in EventEmitter" #38599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47729818 |
Base commit: d3c28d2 |
Summary: Pull Request resolved: facebook#38599 Currently, `metro-config` does not have `hermes-parser` enabled by default. This is because `hermes-parser` does not yet support parsing all of TypeScript's syntax nodes. However, this also means we cannot yet utilize any Flow langauge features that require the use of `hermes-parser` (and are unsupported by Babel). Mapped types falls into this category, so we cannot use them. This backs out a recent change that tried to adopt Flow mapped types in `EventEmitter`, for now. We can revisit after making the necessary changes to `metro-config`. Changelog: [Internal] Reviewed By: pieterv Differential Revision: D47729818 fbshipit-source-id: f562d1456490e89f84c40b8f638ffe5eaf94dbc2
yungsters
force-pushed
the
export-D47729818
branch
from
3523aec
to
2538442
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47729818 |
|
Merged as aa47484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently,
metro-configdoes not havehermes-parserenabled by default. This is becausehermes-parserdoes not yet support parsing all of TypeScript's syntax nodes.However, this also means we cannot yet utilize any Flow langauge features that require the use of
hermes-parser(and are unsupported by Babel). Mapped types falls into this category, so we cannot use them.This backs out a recent change that tried to adopt Flow mapped types in
EventEmitter, for now. We can revisit after making the necessary changes tometro-config.Changelog:
[Internal]
Reviewed By: pieterv
Differential Revision: D47729818