Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually parse .js.flow files with hermes-parser #38774

Closed
wants to merge 1 commit into from
Closed

Actually parse .js.flow files with hermes-parser #38774

wants to merge 1 commit into from

Conversation

SamChou19815
Copy link
Contributor

Summary: Changelog: [Internal]

Differential Revision: D48047348

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Aug 3, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48047348

@analysis-bot
Copy link

analysis-bot commented Aug 3, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,900,000 +4
android hermes armeabi-v7a 7,948,709 +1
android hermes x86 9,297,783 +3
android hermes x86_64 9,199,440 +4
android jsc arm64-v8a 9,485,312 +4
android jsc armeabi-v7a 8,427,019 +2
android jsc x86 9,469,240 +4
android jsc x86_64 9,783,605 +4

Base commit: 36e1a0c
Branch: main

@SamChou19815 @facebook-github-bot
Actually parse .js.flow files with hermes-parser (#38774)
99312a9 
Summary:
Pull Request resolved: #38774

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D48047348

fbshipit-source-id: f5c3d04c84786323f9a01358323315ea5ec50c6f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48047348

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This pull request was successfully merged by @SamChou19815 in 599a2e3.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Aug 4, 2023
@SamChou19815 SamChou19815 deleted the export-D48047348 branch August 5, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamChou19815 @facebook-github-bot @analysis-bot