Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init react runtime start time in performance API (#38328) #38858

Closed
wants to merge 1 commit into from

Conversation

ryancat
Copy link
Contributor

@ryancat ryancat commented Aug 8, 2023

Summary:

This diff adds the two extra markers initializeRuntimeStart and initializeRuntimeEnd to the startup performance API. The runtime start time matches the existing android marker GET_REACT_INSTANCE_MANAGER_START, which is the first marker we have on the RN android app.

Changelog:
[Android][Added] - Add performance.reactNativeStartupTiming.initializeRuntimeStart and performance.reactNativeStartupTiming.initializeRuntimeEnd API

Reviewed By: rshest

Differential Revision: D47941110

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Aug 8, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47941110

@analysis-bot
Copy link

analysis-bot commented Aug 8, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,947,104 +482
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,540,345 +52
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 66d6384
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47941110

ryancat pushed a commit to ryancat/react-native that referenced this pull request Aug 15, 2023
Summary:
Pull Request resolved: facebook#38858

Pull Request resolved: facebook#38328

This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app.

Changelog:
[Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and `performance.reactNativeStartupTiming.initializeRuntimeEnd` API

Reviewed By: rshest

Differential Revision: D47941110

fbshipit-source-id: 7e925dfeb2482e99d218da5025c21ea53171c87f
Summary:
Pull Request resolved: facebook#38858

Pull Request resolved: facebook#38328

This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app.

Changelog:
[Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and `performance.reactNativeStartupTiming.initializeRuntimeEnd` API

Reviewed By: rshest

Differential Revision: D47941110

fbshipit-source-id: 1a589d5e598352a97e5dfacb8ae14a01c46f238a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47941110

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 16, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5063871.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants