Back out "Refactor conditional event emitting to the C++ layer" #38973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48288752 |
Base commit: 9f7dfcc |
|
This pull request was exported from Phabricator. Differential Revision: D48288752 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 12, 2023
…book#38973) Summary: Pull Request resolved: facebook#38973 Original commit changeset: 6c00c2fcfdfd Original Phabricator Diff: D47852371 When facebook#38674 and facebook#38959 are combined, they cause Android apps on Fabric to crash. facebook#38959 is the more urgent fix, so backing out facebook#38674. ## Changelog: [General] [Fixed] - Rolling back change that broke e2e tests until we can figure out why the e2e tests are broken Reviewed By: NickGerleman Differential Revision: D48288752 fbshipit-source-id: 52dac650e0ca43ef094d28f5df4388bc98e20fb9
rozele
force-pushed
the
export-D48288752
branch
from
1a928ea to
affa930
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48288752 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 12, 2023
…book#38973) Summary: Pull Request resolved: facebook#38973 Original commit changeset: 6c00c2fcfdfd Original Phabricator Diff: D47852371 When facebook#38674 and facebook#38959 are combined, they cause Android apps on Fabric to crash. facebook#38959 is the more urgent fix, so backing out facebook#38674. ## Changelog: [General] [Fixed] - Rolling back change that broke e2e tests until we can figure out why the e2e tests are broken Reviewed By: NickGerleman Differential Revision: D48288752 fbshipit-source-id: d9c8b2d1b01ecf6532e92ef6dbce0a5be9c2b57b
rozele
force-pushed
the
export-D48288752
branch
from
affa930 to
1346190
Compare
…book#38973) Summary: Pull Request resolved: facebook#38973 Original commit changeset: 6c00c2fcfdfd Original Phabricator Diff: D47852371 When facebook#38674 and facebook#38959 are combined, they cause Android apps on Fabric to crash. facebook#38959 is the more urgent fix, so backing out facebook#38674. ## Changelog: [General] [Fixed] - Rolling back change that broke e2e tests until we can figure out why the e2e tests are broken Reviewed By: NickGerleman Differential Revision: D48288752 fbshipit-source-id: a3f8efe9bb2657a420a6af7f6b52af37e28d3f3f
|
This pull request was exported from Phabricator. Differential Revision: D48288752 |
rozele
force-pushed
the
export-D48288752
branch
from
1346190 to
5031cc7
Compare
|
This pull request was successfully merged by Eric Rozell in ae88aef. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Original commit changeset: 6c00c2fcfdfd
Original Phabricator Diff: D47852371
Differential Revision: D48288752