Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI command entry points #39075

Closed
wants to merge 2 commits into from
Closed

Refactor CLI command entry points #39075

wants to merge 2 commits into from

Conversation

huntie
Copy link
Member

@huntie huntie commented Aug 18, 2023

Summary:
Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48433284

@analysis-bot
Copy link

analysis-bot commented Aug 18, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,960,400 +205
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,551,197 +22
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8b62200
Branch: main

huntie added a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
a6270bc 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: 124ae5a7731b44b213470b4e4fc7053b9f8d770a
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
df6facd 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 6162a73a134453a04f5cc15c0a2915af720267e4
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
af55952 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: b308e718deda1c4dc18ff0b870a26bfd9ff4ff46
huntie added a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
2055294 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: a5654143686af6df726a6906586771d153e11b7a
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
b18d437 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 28d8af027540a4c7cf07e64bf13eda3a6209f6a9
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
ec11fdc 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 6712fc33744b80a8e3a3aaefc662e450b57e2efe
huntie added a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
a7d6e95 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: a93a0d969d7be9c08fe60ea0ce1124fdd2b8a4db
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
032a15b 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 08d3ec365d3222eb0ed93dbce3dd93df252c5d61
huntie added a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
a7f279f 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: 94fe81c37469e2790519a8e058987e93cc9c0ea6
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
7ab6add 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: c28e45f32abd694d3978c788cc77fbfbec7d045f
huntie added a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
e1e1f9b 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: 34a2e2c34be47a790fd85568b45a27a458cfbc90
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
6980dbb 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: ecf9ee271a3c0f4ee085a9af6ce6c05499434a92
huntie added a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
c1787a8 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: 02c0a2799a7c62444066538ace3095d5dd9d6c2a
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
014c323 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: b3bfa5bbf57bb03f1b73cb754b732f83c563bfac
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
53855ee 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 287c70a253de0fe2b6045a4b3203c8be4f0b483c
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
6851dd9 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 2ff7bc030bfd1bb843d1120dcc8707ab675382bc
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
cf2274a 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 1ab29bb539b94854f275804a55abef5a42dfd0f3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48433284

huntie pushed a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
475b144 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 1fc2ba121988b7de64fc0e69381d71194acba251
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48433284

huntie added a commit to huntie/react-native that referenced this pull request Aug 21, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
9d4041f 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: d4d2cd9d0f1838bc9e7029559ae96135f55969ff
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
260e7f8 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: c29471c4f5d44b90b3d5452949ec0f06a79baf3a
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
9e09bbd 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 721c0e1bf3ae089a51af698e18a2cb3cebaddc2a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48433284

huntie added a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
00d4b62 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: 086069dfc53001f3347433abd1cbd4252cb662d6
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
f2b608b 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 81ee0d73691bcb7520b0e25345e92dae433b41ea
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
81f0d47 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 6c731aad24e6d0f57ab1964f4bbbb7adbeb763e1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48433284

huntie added a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
22c135b 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: 171b1665f13f34daf14047b82ec067a329db2c19
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
7a14b08 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: aeaf3f999e54de917e93a2dabc4fc473e8577849
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
7aa669a 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 86e572e261f0a2dfcf8fa57db29226e7a1a210c3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48433284

huntie added a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
f7be2e9 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: fd9582c93c115844eb2b298476c0f0e4567724bf
Alex Hunt and others added 2 commits August 22, 2023 12:56
@facebook-github-bot
Upgrade CLI, restore prev status check value
34ca91a 
Summary:
Follow-up to facebook#38988.

- Upgrade to RN CLI `12.0.0-alpha.10`.
- Restore previous value check against `/status` response in test scripts (restored in above CLI alpha).

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48432629

fbshipit-source-id: f63b1800713b11f97659e3c9ec8ed0d432e128a0
@huntie @facebook-github-bot
Refactor CLI command entry points (facebook#39075)
f771ca0 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Reviewed By: blakef

Differential Revision: D48433284

fbshipit-source-id: e3bfb485dc77f38592188fee16095d4491e3688b
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
10dcaa0 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: e7ed0a6e6c6f808cd4897c066d7136e4a85b6121
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 22, 2023
@facebook-github-bot
Refactor CLI command entry points (facebook#39075)
83ee430 
Summary:
Pull Request resolved: facebook#39075

Small refactor: reorganise command entry points and types into a consistent pattern.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48433284

fbshipit-source-id: 5cc145b474c8c5cbf350cfee1a1b92091afd9b18
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48433284

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 22, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5276599.

@huntie huntie deleted the export-D48433284 branch August 29, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huntie @facebook-github-bot @analysis-bot