Add detection of logical assignment operators to react-native-babel-preset
#39186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 0c25f19 |
|
@rozele has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Rumor has it Chakra support is getting dropped from react-native-windows, closing this PR for now. |
|
Re-opening while we assess whether this is applicable to JSC. |
|
This pull request was successfully merged by @jonthysell in c90485e. When will my fix make it into a release? | Upcoming Releases |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…preset` (facebook#39186) Summary: Though not currently in use in the RN code, when `react-native-windows` tried to integrate changes up to 7/28/23 (see PR microsoft/react-native-windows#11970) there happened to be a `??=` operator in the `virtualized-lists` package (see [diff here](facebook/react-native@ccc50dd...c168a4f#diff-abeff2daf5909e54a23562e43569de1d5b8db1d7170119eed485b618cdf04ec7R322)). (The offending line was removed in a later commit). The default RNW engine is still Chakra and it couldn't handle the syntax. It looks like the `babel/plugin-proposal-nullish-coalescing-operator` plugin only handles `??`, so to handle `??=` I've added `babel/plugin-proposal-logical-assignment-operators`, which also happens to handle the logical assignment operators `||=` and `&&=`. Closes facebook#31704 ## Changelog: [GENERAL] [FIXED] - Add detection of logical assignment operators to `react-native-babel-preset` Pull Request resolved: facebook#39186 Test Plan: We started using these plugins in RNW's babel config to resolve the issue in our integrate PR. Reviewed By: motiz88 Differential Revision: D50936554 Pulled By: rozele fbshipit-source-id: 0a924b6085524d8c9551a158b91195b1f7448c19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Though not currently in use in the RN code, when
react-native-windowstried to integrate changes up to 7/28/23 (see PR microsoft/react-native-windows#11970) there happened to be a??=operator in thevirtualized-listspackage (see diff here). (The offending line was removed in a later commit).The default RNW engine is still Chakra and it couldn't handle the syntax. It looks like the
@babel/plugin-proposal-nullish-coalescing-operatorplugin only handles??, so to handle??=I've added@babel/plugin-proposal-logical-assignment-operators, which also happens to handle the logical assignment operators||=and&&=.Closes #31704
Changelog:
[GENERAL] [FIXED] - Add detection of logical assignment operators to
react-native-babel-presetTest Plan:
We started using these plugins in RNW's babel config to resolve the issue in our integrate PR.