Fix Transform flip example on new renderer #39259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
Base commit: edff5e9 |
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
javache
force-pushed
the
export-D48905010
branch
from
cd8b0c8 to
2b81cb6
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 5, 2023
Summary: This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 5, 2023
Summary: This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010
javache
force-pushed
the
export-D48905010
branch
from
2b81cb6 to
13ca6c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 5, 2023
Summary: This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010
javache
force-pushed
the
export-D48905010
branch
from
13ca6c6 to
b8eb9a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 5, 2023
Summary: Pull Request resolved: facebook#39259 This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010 fbshipit-source-id: 046ee7ad37d78ee47a7d1ce5fee2081836173cf2
javache
force-pushed
the
export-D48905010
branch
from
b8eb9a8 to
6a5e824
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 5, 2023
Summary: Pull Request resolved: facebook#39259 This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010 fbshipit-source-id: bbee2c9b7319e41a9fcde47d53fc3baeadde91ef
javache
force-pushed
the
export-D48905010
branch
from
6a5e824 to
0674f85
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 5, 2023
Summary: Pull Request resolved: facebook#39259 This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010 fbshipit-source-id: 42d66beb0f21126fba2fe1ecf4ef9768e10d9885
javache
force-pushed
the
export-D48905010
branch
from
0674f85 to
3ec799d
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 6, 2023
Summary: This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010
javache
force-pushed
the
export-D48905010
branch
from
3ec799d to
cc86d15
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 6, 2023
Summary: This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010
javache
force-pushed
the
export-D48905010
branch
from
cc86d15 to
7ce6e9a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 6, 2023
Summary: This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010
javache
force-pushed
the
export-D48905010
branch
from
7ce6e9a to
eebe5be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
Summary: This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample. Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied Reviewed By: christophpurrer Differential Revision: D48905010
javache
force-pushed
the
export-D48905010
branch
from
eebe5be to
f46dd88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48905010 |
|
This pull request has been merged in 850349b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This matches the behaviour we had in the old renderer where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample.
Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied
Differential Revision: D48905010