Add missing type for TextInput.readOnly in Typescript #39281
Closed
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
NickGerleman
approved these changes
Sep 4, 2023
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @antliann in deb8185. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
readOnlyprop is available in theTextInputimplementation (see usage #1, usage #2), but the corresponding Typescript type is currently missing. Those who use Typescript get an invalid prop error when using thereadOnlyprop onTextInput.Having this prop type included in TypeScript would fix the bug above and also would be beneficial for consistency and comprehensive type support.
Notably, this prop is also included in the Flow types here.
Changelog:
[GENERAL] [FIXED] - Add missing type for TextInput.readOnly in Typescript
Test Plan:
N/A