Migrate from legacy to new Hermes CDP handler #39367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motiz88
force-pushed
the
export-D48783980
branch
from
fb89a69 to
31df7da
Compare
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48783980 |
Base commit: b29b393 |
|
This pull request was exported from Phabricator. Differential Revision: D48783980 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39367 Updates React Native to use the new CDP handler provided by the Hermes engine instead of the legacy one (`Connection.cpp`) built into React Native. The new Hermes CDP handler has a simpler & safer design, new features (e.g. `console.log` buffering) and is under active development by the Hermes team. NOTE: Both the legacy and modern handlers are Hermes-specific. In future work, React Native will *wrap* the modern Hermes handler in an engine-agnostic CDP layer implementing additional functionality and managing the lifecycle of debugging sessions more correctly. This diff is the first step of this larger migration. Changelog: [General][Changed] Use new Hermes CDP handler implementation for debugging Differential Revision: D48783980 fbshipit-source-id: 9c8afe6490d85e566047b9df2f2773c482270ae4
motiz88
force-pushed
the
export-D48783980
branch
from
31df7da to
7853100
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48783980 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39367 Updates React Native to use the new CDP handler provided by the Hermes engine instead of the legacy one (`Connection.cpp`) built into React Native. The new Hermes CDP handler has a simpler & safer design, new features (e.g. `console.log` buffering) and is under active development by the Hermes team. NOTE: Both the legacy and modern handlers are Hermes-specific. In future work, React Native will *wrap* the modern Hermes handler in an engine-agnostic CDP layer implementing additional functionality and managing the lifecycle of debugging sessions more correctly. This diff is the first step of this larger migration. Changelog: [General][Changed] Use new Hermes CDP handler implementation for debugging Differential Revision: D48783980 fbshipit-source-id: b3760577c03fb0f79b0bd1c548fa15a8288ad5fb
motiz88
force-pushed
the
export-D48783980
branch
from
7853100 to
19fd6f9
Compare
Summary: Updates React Native to use the new CDP handler provided by the Hermes engine instead of the legacy one (`Connection.cpp`) built into React Native. The new Hermes CDP handler has a simpler & safer design, new features (e.g. `console.log` buffering) and is under active development by the Hermes team. NOTE: Both the legacy and modern handlers are Hermes-specific. In future work, React Native will *wrap* the modern Hermes handler in an engine-agnostic CDP layer implementing additional functionality and managing the lifecycle of debugging sessions more correctly. This diff is the first step of this larger migration. Changelog: [General][Changed] Use new Hermes CDP handler implementation for debugging Reviewed By: cipolleschi Differential Revision: D48783980
motiz88
force-pushed
the
export-D48783980
branch
from
19fd6f9 to
bdc579b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48783980 |
|
This pull request has been merged in 3e7a873. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates React Native to use the new CDP handler provided by the Hermes engine instead of the legacy one (
Connection.cpp) built into React Native. The new Hermes CDP handler has a simpler & safer design, new features (e.g.console.logbuffering) and is under active development by the Hermes team.NOTE: Both the legacy and modern handlers are Hermes-specific. In future work, React Native will wrap the modern Hermes handler in an engine-agnostic CDP layer implementing additional functionality and managing the lifecycle of debugging sessions more correctly. This diff is the first step of this larger migration.
Changelog: [General][Changed] Use new Hermes CDP handler implementation for debugging
Differential Revision: D48783980